#191 ProcessInstance refactor - use isSaved()

metasfresh · Feb 27, 2017 · ece8640 · ece8640
1 parent 90de886
commit ece8640
Showing 1 changed file with 3 additions and 11 deletions.
diff --git a/metasfresh-webui-api/src/main/java/de/metas/ui/web/process/ProcessInstance.java b/metasfresh-webui-api/src/main/java/de/metas/ui/web/process/ProcessInstance.java
@@ -457,18 +457,10 @@ public boolean saveIfValidAndHasChanges(final boolean throwEx)
 	{
 		final Document parametersDocument = getParametersDocument();
 		final DocumentSaveStatus parametersSaveStatus = parametersDocument.saveIfValidAndHasChanges();
-		final boolean saved;
-		if (parametersSaveStatus.hasChangesToBeSaved() || parametersSaveStatus.isError())
+		final boolean saved = parametersSaveStatus.isSaved();
+		if (!saved && throwEx)
 		{
-			saved = false;
-			if (throwEx)
-			{
-				throw new ProcessExecutionException(parametersSaveStatus.getReason());
-			}
-		}
-		else
-		{
-			saved = true;
+			throw new ProcessExecutionException(parametersSaveStatus.getReason());
 		}
 
 		return saved;