use constants instead of hardcoded strings

#681
metasfresh · Nov 16, 2017 · f37188d · f37188d
1 parent 13a6968
commit f37188d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/main/java/de/metas/ui/web/view/ViewRow.java b/src/main/java/de/metas/ui/web/view/ViewRow.java
@@ -261,7 +261,7 @@ public DocumentId getRowId()
 					// NOTE: we have to do this because usually, the root row can have the same ID as one of the included rows,
 					// because the root/aggregated rows are build on demand and they don't really exist in database.
 					// Also see https://github.com/metasfresh/metasfresh-webui-frontend/issues/835#issuecomment-307783959
-					_rowIdEffective = DocumentId.ofString("D" + rowId.toJson());
+					_rowIdEffective = DocumentId.ofString(DocumentId.DOCUMENT_ID_PREFIX + rowId.toJson());
 				}
 			}
 

diff --git a/src/main/java/de/metas/ui/web/window/datatypes/DocumentId.java b/src/main/java/de/metas/ui/web/window/datatypes/DocumentId.java
@@ -43,7 +43,7 @@
 // JSON
 public abstract class DocumentId implements Serializable
 {
-	private static final transient String DOCUMENT_ID_PREFIX = "D";
+	public static final transient String DOCUMENT_ID_PREFIX = "D";
 
 	private static final transient int NEW_ID = -1;