Not all TUs available in Purchase Order Lines

[metas-rc]

Is this a bug or feature request?

• Bug

What is the current behavior?

• Not all TUs are available to choose from in a purchase order line

Which are the steps to reproduce?

• The product Frisee Industrie had a CU-TU for G1 x 10 kg

• I added a new one for G2 x 5

• Create a purchase order (webui)

• Add a line for the product Frisee Industrie
  ** G1 X 10 kg is selected as TU by default

• Try to change this TU
  ** => NOK: THe only value you can set is "None"
  ** => NOK: After setting to NONE you cannot set to G1x10 any more

• For the product Radiesli, there are also 2 TUs : G2x10 and IFCO6410x4

• create a purchase order

• Create a line for Radiesly
  ** => OK: G2x10 is selected by default

• Try to change the TU
  ** => NOK: The only ones you can set are G2x10 and None

• Notes:
  ** the purchase order lines work correctly in swing
  ** Also, in swing, the TUs must be in the mattribute price entries of the product. The 4 TUs I used are all in the pricelists so I was able to add them in purchase orders via swing.
  ** Note that the CU-TU configurations work well on Sales side.

What is the expected or desired behavior?

• The purchase line creation and TU selection must be similar with the one in swing.

[metas-rc]

Followup for #112

[metas-rc]

I verified once again ( after a frontend update) and this time it worked, for the TUs that I introduced in the database via swing and added in the pricelist.
But both TUs were imediately available in sales order, before update.
Please add more TUs in DB and test again before starting to fix.

[metas-rc]

I found another product with TU problems.

[metas-rc]

[teosarca]

debugged and the reason is: your product/packing material is not on price list or this is how the validation rule thinks.

The reason why you were able to add it when using quick input is because there, the price list is not checked.

Technically, on quick input, the packing material is set by de.metas.ui.web.quickinput.orderline.OrderLineQuickInputDescriptorFactory.onProductChangedCallout(ICalloutField).

IMHO, the solution would be to refactor the logic from validation rules and have one place where we are validating which packing materials are allowed for given context.

But that's a request for metasfresh project and not for webui.

[metas-mk]

OK, then. We have to fix that. It shall not be any difference between validation of line editing and quick entry of available products nor Packing material.

[teosarca]

I think the fix it's not so easy, and a big part of it (if not all) would be on metasfresh project.
It would be feasible to fix/implement it when we would refactor all pricing stuff and make sure ALL pricing checkings are using ONE SINGLE API.