Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manufacturing Quickaction: Issue selected HU w/ TU Quantity parm #357

Closed
metas-mk opened this issue May 10, 2017 · 8 comments
Closed

Manufacturing Quickaction: Issue selected HU w/ TU Quantity parm #357

metas-mk opened this issue May 10, 2017 · 8 comments

Comments

@metas-mk
Copy link
Member

Is this a bug or feature request?

Feature request.

What is the current behavior?

Currently, the user can only issue whole HU.

Which are the steps to reproduce?

Do an issue and try to issue only a certain amount of TU of the selected HU.

What is the expected or desired behavior?

It shall be possible to select an HU (via Barcode or manually) and then issue only partially. The user can enter the qty of TU to be used.

@teosarca
Copy link
Member

teosarca commented May 12, 2017

Update: this task is basically implemented and integrated.
But while implementing this i found out the "HU transform - split TUs out of an existing LU" is not working correctly for some cases. We will have to do more testing and create specific tasks to fix here and there.
Pls do a quick IT and let's identify what's working and what's not.

Update2: this issue with HU transform will be fixed on metasfresh/metasfresh#1516

metas-ts added a commit to metasfresh/metasfresh that referenced this issue May 12, 2017
[#357](metasfresh/metasfresh-webui-api-legacy#357) Manufacturing Quickaction: Issue selected HU w/ TU Quantity parm
[#720](metasfresh/metasfresh-webui-frontend-legacy#720) Implement Zoom-into in webUI
[#354](metasfresh/metasfresh-webui-api-legacy#354) Support for Record_ID buttons
[#216](metasfresh/metasfresh-webui-frontend-legacy#216) Button <record_id> does not open according window
[#356](metasfresh/metasfresh-webui-api-legacy#356) Manufacturing Quickaction: Reverse Issue / Receipt
[#724](metasfresh/metasfresh-webui-frontend-legacy#724) Login role selection keyboard down does not scroll automatically
[#1502](#1502) Drop the CU-TU assignment for "No PI" (M_HU_ID=100)
[#725](metasfresh/metasfresh-webui-frontend-legacy#725) Sidelist closes when doubleclick
[#360](metasfresh/metasfresh-webui-api-legacy#360) Material receipt candidates: Error while Receving HUs for a particular case
[#727](metasfresh/metasfresh-webui-frontend-legacy#727) Grid view: reset current page to 1 when filtering
[#716](metasfresh/metasfresh-webui-frontend-legacy#716) Image widget: button to clear current image
[#717](metasfresh/metasfresh-webui-frontend-legacy#717) Sidelist's scrollbar is on wrong container.
[#705](metasfresh/metasfresh-webui-frontend-legacy#705) Debug/Fix why /window/540189 shows empty
[#351](metasfresh/metasfresh-webui-api-legacy#351) Fix NPE when opening Materialdisposition
[#352](metasfresh/metasfresh-webui-api-legacy#352) Introduce JSONLayoutType.primaryLongLabels
[#1460](#1460) The Bestellkontrolle barcodes shall be generated and persisted in database
[#719](metasfresh/metasfresh-webui-frontend-legacy#719) Document references: group them by their top level menu
[metasfresh/metasfresh-admin/#3](metasfresh/metasfresh-admin-legacy#3) create docker image for metasfresh-admin
[#348](metasfresh/metasfresh-webui-api-legacy#348) backend: Implement Zoom-into in webUI
[#280](metasfresh/metasfresh-webui-api-legacy#280) Scan of Barcode "Bestellkontrolle" for Manufacturing execution
[#255](metasfresh/metasfresh-webui-api-legacy#255) Document fields: when receiving empty string values from frontend, convert them to nulls
[#1179](#1179) Process logs are not displayed in Swing

me-45
@metas-lc metas-lc self-assigned this May 12, 2017
@metas-lc
Copy link

IT (partial)

  1. go to manufacturing order and select a docu
  2. press on issue/ receipt
  3. select the co product and press on issue
  4. select a TU as top level (e.g. paloxe) , press on Issue TUs (partial) and add a qty
    => Error: NoSelection...
    => shall not be able to partial issue it

Same happens if you select an LU with multiple TUs (Error: NoSelection)
here shall work

teosarca added a commit to metasfresh/metasfresh that referenced this issue May 13, 2017
teosarca added a commit that referenced this issue May 13, 2017
@teosarca
Copy link
Member

teosarca commented May 13, 2017

Note to IT:

  • please test issuing from:
    ** a LU
    ** a top level TU => not enabled
    ** a TU
    ** an aggregated TU
    ** a LU which contains TUs and aggregated TUs (no idea how to get that case easily :( )
    ** CU
    ** top level CU

  • please do full regression on HU transformations

  • while testing, pls also check the allocations

@metas-lc
Copy link

metas-lc commented May 15, 2017

Case 1. a LU

=> Issue TUs partial is enabled. Add qty of TUs => works fine, both left and right side are updated. I can also issue normally OK
(retested OK)

Case 2. a top level TU

=> not enabled (cannot select Issue TUs partial), but i can issue normally OK
(retested OK)

Case 3. a TU

=> Issue TUs partial is enabled. Add qty 1 => works fine, both left and right side are updated.
But I can't issue normally :
Server error
Issuing VHUs is not allowed
OK????
(retested same)

Case 4. an aggregated TU

=> Issue TUs partial is enabled. Add qty of TUs => works fine, both left and right side are updated. I can't issue normally
Server error
Issuing VHUs is not allowed
OK????
(retested, got: Issuing aggregated TUs is not allowed. Please use the quick action which partially issues TUs.)

Case 5. a LU which contains TUs and aggregated TUs (no idea how to get that case easily :( )

=> transform is not working... postponed for now
(retested, partial and normally works) OK

Case 6. CU

=> not enabled (cannot select Issue TUs partial), I can't issue normally
Server error
Issuing VHUs is not allowed
OK???????
(retested, same)

Case 7. top level CU

=> not enabled (cannot select Issue TUs partial), i can issue normally BUT the line does not disappear from right side NOK
(retested, line is gone now OK)

teosarca added a commit to metasfresh/metasfresh that referenced this issue May 18, 2017
teosarca added a commit that referenced this issue May 18, 2017
… receipt"

it was failing with "string IDs cannot be converted to int"

#357 (comment)
@teosarca
Copy link
Member

teosarca commented May 18, 2017

Fixed another test case:

  • press to receive an LU
  • split out an LU
  • click on "Select all on this page"
  • run "Create material receipt"
    => was throwing an error about "cannot convert String DocumentIDs to integer"
    (lili: checked while IT2, works now )

teosarca added a commit to metasfresh/metasfresh that referenced this issue May 18, 2017
teosarca added a commit that referenced this issue May 18, 2017
@teosarca
Copy link
Member

teosarca commented May 18, 2017

Fixed another case:

  • issue an top level CU
  • reverse => ERROR
    Also pls make sure we can reverse ANY of the issued HUs (ofc, if they were not already processed).
    (lili: tested on IT2, works)

@teosarca
Copy link
Member

@metas-lc i've fixed some cases on this issue.
about that "VHU error", i will also check with @metas-mk if we still needed, because it would take some time to fix.

@metas-lc
Copy link

metas-lc commented May 19, 2017

IT2

retested cases above. Most issues got fixed, including the other cases

remaining questions:
what should happen when you want to use "Issue selected HUs" on:

  • a TU from an LU (aggregated or not). For now you get "Issuing aggregated TUs is not allowed. Please use the quick action which partially issues TUs"
  • a VHU from a TU. For now you get "Issuing VHUs is not allowed"

created issue: #394

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants