webui views: sysconfig to configure how much time we keep the views before we expire them #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metas-ts
approved these changes
Apr 16, 2020
teosarca
reviewed
Apr 16, 2020
| private final Cache<ViewId, IView> views; | ||
|
|
||
| public DefaultViewsRepositoryStorage(final int viewExpirationTimeoutInHours) | ||
| public DefaultViewsRepositoryStorage(final long viewExpirationTimeoutInMinutes) |
There was a problem hiding this comment.
@TheBestPessimist @metas-ts we shall avoid using primitive (and meaningless) types.
In this case, Duration would be suitable.
There was a problem hiding this comment.
THere's no way in java 8 to transform a Duration -> Timeunit.
I wanted to use duration in the first place, but didn't see a good way. More details: https://stackoverflow.com/questions/26581708/converting-timeunit-to-chronounit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
metasfresh/metasfresh#6480