hide some processes if not picker role

metasfresh/metasfresh#4967

src/main/java/de/metas/ui/web/pickingV2/productsToPick/process/ProductsToPickViewBasedProcess.java

@@ -8,6 +8,7 @@
 import de.metas.handlingunits.picking.PickingCandidate;
 import de.metas.process.IProcessPrecondition;
 import de.metas.process.ProcessPreconditionsResolution;
+import de.metas.ui.web.pickingV2.PickingConstantsV2;
 import de.metas.ui.web.pickingV2.productsToPick.ProductsToPickRow;
 import de.metas.ui.web.pickingV2.productsToPick.ProductsToPickView;
 import de.metas.ui.web.process.adprocess.ViewBasedProcessTemplate;
@@ -42,6 +43,16 @@ public abstract class ProductsToPickViewBasedProcess extends ViewBasedProcessTem
 	@Override
 	protected abstract ProcessPreconditionsResolution checkPreconditionsApplicable();
 
+	protected final boolean isPickerProfile()
+	{
+		return getViewProfileId() == null;
+	}
+
+	protected final boolean isReviewProfile()
+	{
+		return PickingConstantsV2.PROFILE_ID_ProductsToPickView_Review.equals(getViewProfileId());
+	}
+
 	@Override
 	protected final ProductsToPickView getView()
 	{

src/main/java/de/metas/ui/web/pickingV2/productsToPick/process/ProductsToPick_4EyesReview_ProcessAll.java

@@ -57,6 +57,11 @@ public class ProductsToPick_4EyesReview_ProcessAll extends ProductsToPickViewBas
 	@Override
 	protected ProcessPreconditionsResolution checkPreconditionsApplicable()
 	{
+		if (!isPickerProfile())
+		{
+			return ProcessPreconditionsResolution.rejectWithInternalReason("only picker shall be allowed to process");
+		}
+
 		if (!getView().isApproved())
 		{
 			return ProcessPreconditionsResolution.rejectWithInternalReason("not all rows were approved");

src/main/java/de/metas/ui/web/pickingV2/productsToPick/process/ProductsToPick_PickSelected.java

@@ -41,6 +41,11 @@ public class ProductsToPick_PickSelected extends ProductsToPickViewBasedProcess
 	@Override
 	protected ProcessPreconditionsResolution checkPreconditionsApplicable()
 	{
+		if (!isPickerProfile())
+		{
+			return ProcessPreconditionsResolution.rejectWithInternalReason("only picker shall pick");
+		}
+
 		final List<ProductsToPickRow> selectedRows = getSelectedRows();
 		if (selectedRows.isEmpty())
 		{

src/main/java/de/metas/ui/web/pickingV2/productsToPick/process/ProductsToPick_Request4EyesReview.java

@@ -34,7 +34,7 @@ public class ProductsToPick_Request4EyesReview extends ProductsToPickViewBasedPr
 	@Override
 	protected ProcessPreconditionsResolution checkPreconditionsApplicable()
 	{
-		if (PickingConstantsV2.PROFILE_ID_ProductsToPickView_Review.equals(getViewProfileId()))
+		if (isReviewProfile())
 		{
 			return ProcessPreconditionsResolution.rejectWithInternalReason("already reviewing");
 		}

src/main/java/de/metas/ui/web/pickingV2/productsToPick/process/ProductsToPick_SetPackingInstructions.java

@@ -52,6 +52,11 @@ public class ProductsToPick_SetPackingInstructions extends ProductsToPickViewBas
 	@Override
 	protected ProcessPreconditionsResolution checkPreconditionsApplicable()
 	{
+		if (!isPickerProfile())
+		{
+			return ProcessPreconditionsResolution.rejectWithInternalReason("only picker shall pack");
+		}
+
 		if (!streamRowsEligibleForPacking().findAny().isPresent())
 		{
 			return ProcessPreconditionsResolution.rejectWithInternalReason("no eligible rows were selected");