Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide v11 / CAMT 54 File Import #142

Closed
metasnw opened this issue Feb 18, 2017 · 9 comments
Closed

Provide v11 / CAMT 54 File Import #142

metasnw opened this issue Feb 18, 2017 · 9 comments
Assignees
@metas-rc
Labels
branch:master branch:release priority:high type:enhancement
Milestone
2017-40

Comments

@metasnw
Copy link
Member

metasnw commented Feb 18, 2017

allow dragging a v11 file into an esr import and start processing it as if I had used the process "v11 importieren"
image
@metas-mk
Copy link
Member

As first step I would suggest to not directly start the import. Instead press the corresponding process button after and initially setting the attachment as "file to to be processed". This way we don't mix it up with the default attachment functionality.

@metasnw
Copy link
Member Author

metasnw commented Feb 18, 2017

yes, got your point. do you think we can still make it drag and drop cause its pretty cool?

@teosarca
Copy link
Member

or... we can implement some hook mechanism which identifies that we are taking about "v11 import file" and asks the user if we wants to import it.

But this feature shall be ADDITIONAL to #144

wdyt?

@metasnw metasnw changed the title Provide v11 File Import Provide v11 / CAMT 54 File Import Aug 9, 2017
@metas-mk metas-mk added this to the 2017-37 milestone Sep 11, 2017
teosarca added a commit to metasfresh/metasfresh that referenced this issue Sep 14, 2017
@teosarca
mark AD_AttachmentEntry.FileName as identifier
9ea4133 
instead of ContentType

metasfresh/metasfresh-webui-api-legacy#142
teosarca added a commit to metasfresh/metasfresh that referenced this issue Sep 14, 2017
@teosarca
ESR_Import.AD_AttachmentEntry_ID
0f32457 
metasfresh/metasfresh-webui-api-legacy#142
teosarca added a commit to metasfresh/metasfresh that referenced this issue Sep 14, 2017
@teosarca
Attachment.retrieveAttachmentEntryById shall enforce attachmentId whe…
a581e95 
…n provided

metasfresh/metasfresh-webui-api-legacy#142
teosarca added a commit to metasfresh/metasfresh that referenced this issue Sep 14, 2017
@teosarca
cleanup IAttachmentBL
3943d6a 
metasfresh/metasfresh-webui-api-legacy#142
teosarca added a commit to metasfresh/metasfresh that referenced this issue Sep 14, 2017
@teosarca
ESRImportEnqueuer
5cb1be4 
metasfresh/metasfresh-webui-api-legacy#142
teosarca added a commit to metasfresh/metasfresh that referenced this issue Sep 14, 2017
@teosarca
ESR_Import_LoadFromAttachmentEntry
5d0fcdd 
metasfresh/metasfresh-webui-api-legacy#142
teosarca added a commit that referenced this issue Sep 14, 2017
@teosarca
minor cleanup AttachmentBL API
38a6de2 
#142
teosarca added a commit that referenced this issue Sep 14, 2017
@teosarca
MAJOR: process: use context single document to to resolve lookup cont…
7430de4 
…ext values

i.e. when resolving context variables if not found we shall fallback to
context document

#142
@teosarca
Copy link
Member

update: introduced a new process which will allow to import from attachments.
image

image

@teosarca
Copy link
Member

note to IT:

  • test the new process (but before u have to upload the file)
  • regression: make sure the old process is still working (swing only); also make sure the file was attached
  • regression: briefly check process parameters in webui, if they are resolved, dropdowns are ok etc (reason: 7430de4 )

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Sep 15, 2017
@metas-ts
Update ReleaseNotes.md
88b86e3 
[#2218](#2218) User would
like to import default values for contact and address
[#2245](#2445) Support
quantity in flatrate term import
[#2361](#2361) Invoice
Candidates Action Approval for Invoicing
[#2387](#2387)
Autocomplete for zip / postal code and city
[#2298](#2298) Introduce
source-HU to fine-Picking
[#2247](#2474) Extend
Partner Import with ad_language
[#585](metasfresh/metasfresh-webui-api-legacy#585)
Lookup validation rule shall support @CtxName/Default@ annotation
[#2459](#2459) shipto and
billto contact / user
[#2436](#2436) Use
default values for IsShipTo and isBillTo when importing bpartner
[#2457](#2457) Duplicate
locations on partner import when multiple contacts
[#2463](#2463) Extend
Partner Import to support contact flags
[#142](metasfresh/metasfresh-webui-api-legacy#142)
Provide v11 / CAMT 54 File Import
[#2429](#2429) hide qty
TU when HU name is empty
[#2423](#2423) fix
jaspers for vendor return with quality issue
[#2430](#2430) Invoice
candidate close is retrieving the invoice candidates out of transaction
[#547](metasfresh/metasfresh-webui-api-legacy#547)
Provide mass export of Data to Excel
[#570](metasfresh/metasfresh-webui-api-legacy#570)
clicking print on non-document window shows error page
[#2431](#2431) Product
Filter in Handling Unit Editor
[#2413](#2413) Make
request status a search field in request window
[metasfresh/metasfresh-parent-legacy#14](metasfresh/metasfresh-parent-legacy#14)
Look for a way of not having the "placeholder" on local builds
[#178](metasfresh/metasfresh-webui-api-legacy#178)
Have Letter Feature in Sales Order Window
[#2401](#2401) vendor
return with quality discount
[#2434](#2434) Make field
ad_user_incharge_id from C_Flatrate_Term optional
[#2397](#2397) Import and
Store Contract meta-data e.g. startdate on flatrate
[#2412](#2412)
OrderCheckout Jaspers display empty C_BPartner_Product.ProductName
[#582](metasfresh/metasfresh-webui-api-legacy#582)
Cannot invoice disposal's invoice candidates
[#1060](metasfresh/metasfresh-webui-frontend-legacy#1060)
Locale viewing and editing in User Interface
[#583](metasfresh/metasfresh-webui-api-legacy#583)
Provide the document's standard actions
[#581](metasfresh/metasfresh-webui-api-legacy#581)
API to provide user session's locale

me-45
@metas-mk metas-mk modified the milestones: 2017-37, 2017-40 Oct 4, 2017
@metas-rc
Copy link
Member

metas-rc commented Oct 4, 2017 •
edited
Loading

Results of IT

  • OK: The new process works well with cam54 files.
  • OK: The new process works with v11 files.
  • OK: Regression went fine

NOK 1)
In case of trying to import the same file again, I get " File not imported"error.
The reason for this bug is that our warnings with yes/no confirmations and our other swing messages are not supported by webui.
The sys config does not allow any options of ignoring the fact that a file is duplicated.
We have only these 2 valid values: W - Warning with buttons Yes and No, E -Entirely, Warning with OK button.
How shall we proceede with this part in webui?
Stacktrace provided in this pastebin: https://pastebin.com/8qJ3gNKU

NOK 2)
After the lines are imported, I have to refresh the page in order to see them.

@metasnw
Copy link
Member Author

metasnw commented Oct 4, 2017

hi @metas-rc
please create follow ups for them.
this issue is fine as it already can be used.

@metas-rc metas-rc mentioned this issue Oct 4, 2017
Open
teosarca added a commit to metasfresh/metasfresh that referenced this issue Oct 4, 2017
@teosarca
ProcessExecutionResult.recordToRefreshAfterExecution
1f71820 
metasfresh/metasfresh-webui-api-legacy#142
teosarca added a commit to metasfresh/metasfresh that referenced this issue Oct 4, 2017
@teosarca
SYSCONFIG_PreventDuplicateImportFiles: consider empty or "-" string a…
b14877a 
…s nothing set

metasfresh/metasfresh-webui-api-legacy#142
teosarca added a commit to metasfresh/metasfresh that referenced this issue Oct 4, 2017
@teosarca
after ESR import, ask the framework to refresh the ESR_Import
b09f066 
NOK2 of
metasfresh/metasfresh-webui-api-legacy#142 (comment)
teosarca added a commit that referenced this issue Oct 4, 2017
@teosarca
remove unused ADProcessInstanceController.viewRepo
d384a32 
#142
teosarca added a commit that referenced this issue Oct 4, 2017
@teosarca
after process execution, refresh required documents
4d535d6 
#142
@teosarca
Copy link
Member

teosarca commented Oct 4, 2017

fixed NOK2.

@metas-rc metas-rc self-assigned this Oct 5, 2017
@metas-rc metas-rc mentioned this issue Oct 5, 2017
Open
@metas-rc
Copy link
Member

metas-rc commented Oct 5, 2017

Results of IT2:
The NOK2 was not fixed yet. I created a followup for it: #622

@metas-rc metas-rc closed this as completed Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metas-rc metas-rc

Labels
branch:master branch:release priority:high type:enhancement
Projects
None yet
Milestone
2017-40
Development

No branches or pull requests
5 participants
@teosarca @metas-ts @metas-mk @metas-rc @metasnw