Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invoice candidate close is retrieving the invoice candidates out of transaction #2430

Closed
teosarca opened this issue Sep 12, 2017 · 1 comment
Closed

Invoice candidate close is retrieving the invoice candidates out of transaction #2430

teosarca opened this issue Sep 12, 2017 · 1 comment
Labels
branch:release bug_please_use_type:bug_instead type:bug

Comments

@teosarca
Copy link
Member

Is this a bug or feature request?

bug

What is the current behavior?

Which are the steps to reproduce?

  • browse some invoice candidates
  • select some and run "Auswahl Schließen" (close)
  • in console you get:

org.adempiere.exceptions.AdempiereException: Cannot get trxName from object: ProcessInfo{title=Auswahl Schließen, AD_Process_ID=540687, AD_PInstance_ID=1596809, AD_Table_ID=540270, Record_ID=1004103, Classname=de.metas.invoicecandidate.process.C_Invoice_Candidate_Close, jrDesiredOutputType=PDF}. Returning null.
	at org.adempiere.ad.wrapper.CompositeInterfaceWrapperHelper.getTrxName(CompositeInterfaceWrapperHelper.java:155)
	at org.adempiere.model.InterfaceWrapperHelper.getTrxName(InterfaceWrapperHelper.java:642)
	at org.adempiere.model.InterfaceWrapperHelper.getTrxName(InterfaceWrapperHelper.java:616)
	at org.adempiere.ad.dao.impl.QueryBuilder.setContext(QueryBuilder.java:150)
	at org.adempiere.ad.dao.impl.QueryBL.createQueryBuilder(QueryBL.java:51)
	at de.metas.invoicecandidate.process.C_Invoice_Candidate_Close.retrieveSelectedCandidates(C_Invoice_Candidate_Close.java:62)
	at de.metas.invoicecandidate.process.C_Invoice_Candidate_Close.doIt(C_Invoice_Candidate_Close.java:45)
	at de.metas.process.JavaProcess.startProcess(JavaProcess.java:288)
	at de.metas.process.ProcessExecutor.startJavaProcess(ProcessExecutor.java:563)
	at de.metas.process.ProcessExecutor.startJavaOrScriptProcess(ProcessExecutor.java:459)
	at de.metas.process.ProcessExecutor.access$5(ProcessExecutor.java:448)
	at de.metas.process.ProcessExecutor$1.run(ProcessExecutor.java:223)
	at org.adempiere.ad.trx.api.impl.TrxCallableWrappers$3.call(TrxCallableWrappers.java:145)
	at org.adempiere.ad.trx.api.impl.TrxCallableWrappers$3.call(TrxCallableWrappers.java:1)
	at org.adempiere.ad.trx.api.impl.AbstractTrxManager.call0(AbstractTrxManager.java:771)
	at org.adempiere.ad.trx.api.impl.AbstractTrxManager.call(AbstractTrxManager.java:683)
	at org.adempiere.ad.trx.api.impl.AbstractTrxManager.call(AbstractTrxManager.java:584)
	at org.adempiere.ad.trx.api.impl.AbstractTrxManager.call(AbstractTrxManager.java:515)
	at org.adempiere.ad.trx.api.impl.AbstractTrxManager.run(AbstractTrxManager.java:500)
	at de.metas.process.ProcessExecutor.executeNow(ProcessExecutor.java:285)
	at de.metas.process.ProcessExecutor.executeSync(ProcessExecutor.java:170)
	at de.metas.process.ProcessExecutor.access$1(ProcessExecutor.java:129)
	at de.metas.process.ProcessExecutor$Builder.executeSync(ProcessExecutor.java:653)
	at de.metas.ui.web.process.adprocess.ADProcessInstanceController.executeADProcess(ADProcessInstanceController.java:284)
	at de.metas.ui.web.process.adprocess.ADProcessInstanceController.startProcess(ADProcessInstanceController.java:258)
	at de.metas.ui.web.process.ProcessRestController.lambda$11(ProcessRestController.java:252)
	at de.metas.ui.web.process.adprocess.ADProcessInstancesRepository.forProcessInstanceWritable(ADProcessInstancesRepository.java:380)
	at de.metas.ui.web.process.ProcessRestController.lambda$10(ProcessRestController.java:251)
	at de.metas.ui.web.window.controller.Execution$ExecutionBuilder.lambda$2(Execution.java:237)
	at de.metas.ui.web.window.controller.Execution$ExecutionBuilder.execute(Execution.java:260)
	at de.metas.ui.web.process.ProcessRestController.startProcess(ProcessRestController.java:249)
	at sun.reflect.GeneratedMethodAccessor1208.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:205)
	at org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:133)
	at org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:97)
	at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:827)
	at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:738)
	at org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:85)
	at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:963)
	at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:897)
	at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:970)
	at org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:861)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:635)
	at org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:846)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:742)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
	at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
	at org.springframework.boot.web.filter.ApplicationContextHeaderFilter.doFilterInternal(ApplicationContextHeaderFilter.java:55)
	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
	at de.metas.ui.web.config.WebConfig$1.doFilter(WebConfig.java:82)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
	at de.metas.ui.web.config.ServletLoggingFilter.doFilter(ServletLoggingFilter.java:89)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
	at de.metas.ui.web.config.CORSFilter.doFilter(CORSFilter.java:85)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
	at org.springframework.boot.actuate.trace.WebRequestTraceFilter.doFilterInternal(WebRequestTraceFilter.java:110)
	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:317)
	at org.springframework.security.web.access.intercept.FilterSecurityInterceptor.invoke(FilterSecurityInterceptor.java:127)
	at org.springframework.security.web.access.intercept.FilterSecurityInterceptor.doFilter(FilterSecurityInterceptor.java:91)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331)
	at org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:114)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331)
	at org.springframework.security.web.session.SessionManagementFilter.doFilter(SessionManagementFilter.java:137)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331)
	at org.springframework.security.web.authentication.AnonymousAuthenticationFilter.doFilter(AnonymousAuthenticationFilter.java:111)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331)
	at org.springframework.security.web.servletapi.SecurityContextHolderAwareRequestFilter.doFilter(SecurityContextHolderAwareRequestFilter.java:170)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331)
	at org.springframework.security.web.savedrequest.RequestCacheAwareFilter.doFilter(RequestCacheAwareFilter.java:63)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331)
	at org.springframework.security.web.authentication.logout.LogoutFilter.doFilter(LogoutFilter.java:116)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331)
	at org.springframework.security.web.header.HeaderWriterFilter.doFilterInternal(HeaderWriterFilter.java:64)
	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331)
	at org.springframework.security.web.context.SecurityContextPersistenceFilter.doFilter(SecurityContextPersistenceFilter.java:105)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331)
	at org.springframework.security.web.context.request.async.WebAsyncManagerIntegrationFilter.doFilterInternal(WebAsyncManagerIntegrationFilter.java:56)
	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331)
	at de.metas.ui.web.config.CORSFilter.doFilter(CORSFilter.java:85)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331)
	at org.springframework.security.web.FilterChainProxy.doFilterInternal(FilterChainProxy.java:214)
	at org.springframework.security.web.FilterChainProxy.doFilter(FilterChainProxy.java:177)
	at org.springframework.web.filter.DelegatingFilterProxy.invokeDelegate(DelegatingFilterProxy.java:346)
	at org.springframework.web.filter.DelegatingFilterProxy.doFilter(DelegatingFilterProxy.java:262)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
	at org.springframework.web.filter.RequestContextFilter.doFilterInternal(RequestContextFilter.java:99)
	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
	at org.springframework.web.filter.HttpPutFormContentFilter.doFilterInternal(HttpPutFormContentFilter.java:105)
	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
	at org.springframework.web.filter.HiddenHttpMethodFilter.doFilterInternal(HiddenHttpMethodFilter.java:81)
	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
	at org.springframework.session.web.http.SessionRepositoryFilter.doFilterInternal(SessionRepositoryFilter.java:167)
	at org.springframework.session.web.http.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:80)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
	at org.springframework.web.filter.CharacterEncodingFilter.doFilterInternal(CharacterEncodingFilter.java:197)
	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
	at org.springframework.boot.actuate.autoconfigure.MetricsFilter.doFilterInternal(MetricsFilter.java:106)
	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:198)
	at org.apache.catalina.core.StandardContextValve.__invoke(StandardContextValve.java:96)
	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java)
	at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:478)
	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140)
	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:80)
	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87)
	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342)
	at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:799)
	at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
	at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:861)
	at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1455)
	at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
	at java.lang.Thread.run(Thread.java:748)

What is the expected or desired behavior?

It shall use current transaction.
At the moment, because of the failure, it was retriving (and then changing) those invoice candidates, out of transaction.
teosarca added a commit that referenced this issue Sep 12, 2017
@teosarca
close invoice candidates using current trx
40a7dcf 
#2430
@metas-dh
Copy link
Member

Results of IT1
tested in mf15

  • action "Auswahl Schließen" (close) for selected invoice candidates: no exception in console, OK
  • selected invoice candidates: closed after the action, cannot be invoiced anymore: OK

metas-ts added a commit that referenced this issue Sep 15, 2017
@metas-ts
Update ReleaseNotes.md
88b86e3 
[#2218](#2218) User would
like to import default values for contact and address
[#2245](#2445) Support
quantity in flatrate term import
[#2361](#2361) Invoice
Candidates Action Approval for Invoicing
[#2387](#2387)
Autocomplete for zip / postal code and city
[#2298](#2298) Introduce
source-HU to fine-Picking
[#2247](#2474) Extend
Partner Import with ad_language
[#585](metasfresh/metasfresh-webui-api-legacy#585)
Lookup validation rule shall support @CtxName/Default@ annotation
[#2459](#2459) shipto and
billto contact / user
[#2436](#2436) Use
default values for IsShipTo and isBillTo when importing bpartner
[#2457](#2457) Duplicate
locations on partner import when multiple contacts
[#2463](#2463) Extend
Partner Import to support contact flags
[#142](metasfresh/metasfresh-webui-api-legacy#142)
Provide v11 / CAMT 54 File Import
[#2429](#2429) hide qty
TU when HU name is empty
[#2423](#2423) fix
jaspers for vendor return with quality issue
[#2430](#2430) Invoice
candidate close is retrieving the invoice candidates out of transaction
[#547](metasfresh/metasfresh-webui-api-legacy#547)
Provide mass export of Data to Excel
[#570](metasfresh/metasfresh-webui-api-legacy#570)
clicking print on non-document window shows error page
[#2431](#2431) Product
Filter in Handling Unit Editor
[#2413](#2413) Make
request status a search field in request window
[metasfresh/metasfresh-parent-legacy#14](metasfresh/metasfresh-parent-legacy#14)
Look for a way of not having the "placeholder" on local builds
[#178](metasfresh/metasfresh-webui-api-legacy#178)
Have Letter Feature in Sales Order Window
[#2401](#2401) vendor
return with quality discount
[#2434](#2434) Make field
ad_user_incharge_id from C_Flatrate_Term optional
[#2397](#2397) Import and
Store Contract meta-data e.g. startdate on flatrate
[#2412](#2412)
OrderCheckout Jaspers display empty C_BPartner_Product.ProductName
[#582](metasfresh/metasfresh-webui-api-legacy#582)
Cannot invoice disposal's invoice candidates
[#1060](metasfresh/metasfresh-webui-frontend-legacy#1060)
Locale viewing and editing in User Interface
[#583](metasfresh/metasfresh-webui-api-legacy#583)
Provide the document's standard actions
[#581](metasfresh/metasfresh-webui-api-legacy#581)
API to provide user session's locale

me-45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch:release bug_please_use_type:bug_instead type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@teosarca @metas-ts @metas-dh