Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Picking Window: Open HU Selection window filtering #557

Closed
metas-mk opened this issue Aug 30, 2017 · 1 comment
Closed

Picking Window: Open HU Selection window filtering #557

metas-mk opened this issue Aug 30, 2017 · 1 comment
Labels
branch:master branch:release priority:high type:enhancement
Milestone
2017-35

Comments

@metas-mk
Copy link
Member

Is this a bug or feature request?

Feature Request

What is the current behavior?

Currently, the HU Selection window is opened with all Handling Units available.

Which are the steps to reproduce?

Open and see.

What is the expected or desired behavior?

The Handling Units shall initially be opened only w/ Handling Units fitting to the selected Picking Line and Product.

image
@metas-mk metas-mk added this to the 2017-35 milestone Aug 30, 2017
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Aug 31, 2017
@metas-ts
HUPickingSlotBL.retrieveAvailableHUsToPick excludes picked HUs
abaf5f9 
also:
* POJOWrapper.toString() instanceName first because if set, it's likely
to be the most significant info
* HandlingUnitsBL: extend getTopLevelHUs to allow
  * filtering via a given predicate
  * allow adding all HUs instead of just toplevel ones
* HUIteratorListener*: minor/cleanup
* FreshProductKey and FreshSwingPackageItems minor/cleanup
* add SQL to remove the process WEBUI_Picking_AddHUToPickingSlot
* add perf indices to M_Picking_Candidate

Picking Window: Open HU Selection window filtering
metasfresh/metasfresh-webui-api-legacy#557
metas-ts added a commit that referenced this issue Aug 31, 2017
@metas-ts
WEBUI_Picking_OpenHUsToPick calls IHUPickingSlotBL to get pickable HUs
16738e5 
Also:
* CreateViewRequest: add javadoc (thx @teosarca)
* Remove the obsolete process WEBUI_Picking_AddHUToPickingSlot
* SqlParamsCollector undeprecate collectAll(List) but made it package
only. For other uses, add collectAll(ISqlQueryFilter)
* PickingCandidateCommand: ignore inactive records
* CreateViewRequest, DocumentFilter, HUIdsFilterHelper,
WEBUI_Picking_PickSelectedHU and SqlViewFactory: minor

557: Picking Window: Open HU Selection window filtering 

Task-Url: #557
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Aug 31, 2017
@metas-ts
HUQueryBuilder: addOnlyHUIds with empty list will select *no HUs*..
5ac94e6 
..as opposed to *all HUs*. If you don't dan't to restrict by H_HU_IDs,
then don't call the method, or call if with null if you must.

also:
* IStorageEngine: javadoc, minor
* HUPickingSlotBL, InArrayQueryFilter: minor
* HUPickingSlotBL_RetrieveAvailableHUsToPickTests: cleanup, minor
Picking Window: Open HU Selection window filtering
metasfresh/metasfresh-webui-api-legacy#557
@metas-ts metas-ts mentioned this issue Aug 31, 2017
Merged
metas-ts added a commit that referenced this issue Aug 31, 2017
@metas-ts
If no HU matches, then do *not* show every HU
2e01d97 
Also:
* CreateViewRequest: javadoc
* WEBUI_Picking_OpenHUsToPick: minor formatting

557: Picking Window: Open HU Selection window filtering 

Task-Url: #557
metas-ts added a commit that referenced this issue Aug 31, 2017
@metas-ts
HUEditorViewRepository distinguish between "no restriction" and "no HUs"
44285f5 
..in retrieveHUIdsEffective()

Also 
* HUIdsFilterHelper: minor javadoc

557: Picking Window: Open HU Selection window filtering 

Task-Url: #557
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Aug 31, 2017
@metas-ts
minor
df83e99 
557: Picking Window: Open HU Selection window filtering 

Task-Url: metasfresh/metasfresh-webui-api-legacy#557
metas-ts added a commit that referenced this issue Aug 31, 2017
@metas-ts
Fix: for filterOnlyIds, empty still needs to mean "no restriction"
d921e1c 
557: Picking Window: Open HU Selection window filtering 
Task-Url: #557
metas-ts added a commit that referenced this issue Aug 31, 2017
@metas-ts
minor
400b1d9 
557: Picking Window: Open HU Selection window filtering 

Task-Url: #557
@metas-ts metas-ts removed their assignment Sep 1, 2017
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Sep 1, 2017
@metas-ts
Update ReleaseNotes.md
8a86953 
[#553](metasfresh/metasfresh-webui-api-legacy#553)
webui notification-test fails
[#1157](metasfresh/metasfresh-webui-frontend-legacy#1157)
Delete User Notifications
[#2145](#2145) Partial
Internal usage action in Handling Unit Editor
 [#529](#529) Possibility
to easily create more than 1 referenced Doc per Invoice
 [#557](metasfresh/metasfresh-webui-api-legacy#557)
Picking Window: Open HU Selection window filtering
 [#560](metasfresh/metasfresh-webui-api-legacy#560)
Picking: don't allow picking included rows
[#556](metasfresh/metasfresh-webui-api-legacy#556)
Picking Window Main View adjustments
[#551](metasfresh/metasfresh-webui-api-legacy#551)
verify if lookup value is still valid
[#2237](#2237) Order
Control Report Attribute missing
[#528](metasfresh/metasfresh-webui-api-legacy#528)
Exception when opening PP Order issue / receipt
[#2102](#2102) maven
change "local" version from 1.0.0 to 10.0.0
[#1876](#1876) New CU
Labels
[#1142](metasfresh/metasfresh-webui-frontend-legacy#1142)
issue panel closes right after you issue a product
[#54](metasfresh/metasfresh-webui-api-legacy#54)
Implement endpoint for document cloning
[#549](metasfresh/metasfresh-webui-api-legacy#549)
Validcombination Window does not allow NEW in WebUI
[#2245](#2245) Replace
description field by memo in B2C
[#2258](#2258) add due
date to request grid view
[#2247](#2247) Make
Request Type a search field
[#2260](#2260) SQL -
problem to rollout master build to DB with issue-build

me-45
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Sep 4, 2017
@metas-ts
Fix a regression, thanks to @metas-rc and @metas-lc
11c7cd2 
Picking Window: Open HU Selection window filtering
metasfresh/metasfresh-webui-api-legacy#557
@metas-dh
Copy link
Member

metas-dh commented Sep 6, 2017

Results of IT1
tested in mf15

  1. Create a new sales order, for product A, in warehouse X
  2. Create a purchase order I, for product A, warehouse X (same packing item as used in sales order)
  3. Create another purchase order II, for product B, warehouse X
  4. Create a 3rd purchase order III, for product A, warehouse Y
  5. Open Material Receipt Candidates for all purchase orders, and receive the products (note the HU values!), BUT not the whole qty!
  6. Open Picking Terminal, select your sales orderline, press Pick
  7. In Picking Terminal, select a Picking Slot and press Open HU selection window:
  • HUs received for purchase order I are displayed and selectable, since it's the same product as ordered and the correct warehouse: OK
  • HUs received for purchase order II are not displayed, since another product was ordered and received: OK
  • HUs received for purchase order III are not displayed, since the product was received in another warehouse: OK
  1. Select the HUs of product A, pick them and process the picking
  2. Go back to Material Receipt Candidates, and create receipts for purchase order I (note the HU values!):
  • receive some qty, but with a different packing item
  • receive some qty, then do Korrektur, so the HUs will be destroyed
  1. Check Handling Unit Editor:
  • remaining qty from purchase orders which are not yet received have HU status Planning
  • HUs from Korrektur have status Destroyed
  1. Open Picking Terminal again for your sales order, and check the Open HU selection window:
  • HUs which were picked before are not displayed anymore: OK
  • HUs which were destroyed with Korrektur are not displayed: OK
  • HUs with status Planning from purchase order I are not displayed: OK
  • HUs received for purchase order I with the different packing item are displayed and selectable: OK for now, might be changed in the future

@metas-dh metas-dh closed this as completed Sep 6, 2017
metas-ts added a commit that referenced this issue Sep 11, 2017
@metas-ts
Another fix related to "If no HU matches, then do *not* show every HU"
b8b0144 
Also PPOrderLinesView: minor

557: Picking Window: Open HU Selection window filtering 
Task-Url: #557
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch:master branch:release priority:high type:enhancement
Projects
None yet
Milestone
2017-35
Development

No branches or pull requests
3 participants
@metas-ts @metas-mk @metas-dh