Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webui notification-test fails #553

Closed
metas-ts opened this issue Aug 30, 2017 · 4 comments
Closed

webui notification-test fails #553

metas-ts opened this issue Aug 30, 2017 · 4 comments
Labels
branch:master branch:release priority:high type:bug

Comments

@metas-ts
Copy link
Member

metas-ts commented Aug 30, 2017 •
edited
Loading

Is this a bug or feature request?

Bug

What is the current behavior?

currently, the notification "testing endpoint" does not work

Which are the steps to reproduce?

  • log into the webui with username "user"
  • log in with the swing client also with username "user"
  • invoke the testing endpoint as follows:
curl -u user:password http://app-host:8080/test/ping/notifications

=> There is a notification shown in the swing client, but not in the webui

Note: the fix needs to also end up in branch 2017-09
teosarca referenced this issue Aug 30, 2017
@teosarca
# WARNING: head commit changed in the meantime
a9d83ea 
improve error logging

#545
teosarca referenced this issue Aug 30, 2017
@teosarca
notifications: use a default message in case there was no message pro…
1a75cac 
…vided

#545
@teosarca
Copy link
Member

@metas-ts there was a bug when the Event.getDetailADMessage() was returning null, because AD_Note.AD_Message_ID is mandatory. Fixed that case.
Besides that, IMHO the notifications are working.
Can u pls confirm?

@teosarca
Copy link
Member

(basically it was fixed in #545 )

@metas-ts
Copy link
Member Author

cherry-picked to 2017-09 see https://jenkins.metasfresh.com/job/ops/job/cherry-pick-issue-script/215/

@metas-ts
Copy link
Member Author

Works again as checked by @metas-mk

@metas-ts metas-ts closed this as completed Sep 1, 2017
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Sep 1, 2017
@metas-ts
Update ReleaseNotes.md
8a86953 
[#553](metasfresh/metasfresh-webui-api-legacy#553)
webui notification-test fails
[#1157](metasfresh/metasfresh-webui-frontend-legacy#1157)
Delete User Notifications
[#2145](#2145) Partial
Internal usage action in Handling Unit Editor
 [#529](#529) Possibility
to easily create more than 1 referenced Doc per Invoice
 [#557](metasfresh/metasfresh-webui-api-legacy#557)
Picking Window: Open HU Selection window filtering
 [#560](metasfresh/metasfresh-webui-api-legacy#560)
Picking: don't allow picking included rows
[#556](metasfresh/metasfresh-webui-api-legacy#556)
Picking Window Main View adjustments
[#551](metasfresh/metasfresh-webui-api-legacy#551)
verify if lookup value is still valid
[#2237](#2237) Order
Control Report Attribute missing
[#528](metasfresh/metasfresh-webui-api-legacy#528)
Exception when opening PP Order issue / receipt
[#2102](#2102) maven
change "local" version from 1.0.0 to 10.0.0
[#1876](#1876) New CU
Labels
[#1142](metasfresh/metasfresh-webui-frontend-legacy#1142)
issue panel closes right after you issue a product
[#54](metasfresh/metasfresh-webui-api-legacy#54)
Implement endpoint for document cloning
[#549](metasfresh/metasfresh-webui-api-legacy#549)
Validcombination Window does not allow NEW in WebUI
[#2245](#2245) Replace
description field by memo in B2C
[#2258](#2258) add due
date to request grid view
[#2247](#2247) Make
Request Type a search field
[#2260](#2260) SQL -
problem to rollout master build to DB with issue-build

me-45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch:master branch:release priority:high type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@teosarca @metas-ts