Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

included tab: when zoom into the new window opens with error #1041

Closed
teosarca opened this issue Jul 17, 2017 · 8 comments
Closed

included tab: when zoom into the new window opens with error #1041

teosarca opened this issue Jul 17, 2017 · 8 comments

Comments

@teosarca
Copy link
Member

teosarca commented Jul 17, 2017

Type of issue

Bug

Steps to reproduce

Expected behavior

I was checking it and the problem is refType and refId parameters from the query:

https://w101.metasfresh.com:8443/window/540325?refType=540321&refId=2008396

Problem is that in our case we shall reference the included row and not the header document.
That's why the backend cannot find a connection between those.

I think you shall also introduce refTabId and refRowId as parameters (for frontend),
and when creating the view please also provide the tabId and rowIds array, e.g.

{
"documentType":"540325",
"viewType":"grid",

"referencing":{
  "documentType":"540321",
  "documentId":"2008396",
  "tabId":"1",
  "rowIds":["2002141"]
},
"filters":null
}

(remark the tabId and rowIds properties)
The support for those properties was introduced by metasfresh/metasfresh-webui-api-legacy#506
Endpoint: http://w101.metasfresh.com:8081/swagger-ui.html#!/view-rest-controller/createViewUsingPOST

@teosarca
Copy link
Member Author

rolled on w101

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Jul 20, 2017
[#2028](#2028) New Window for Validcombination in WebUI
[#2027](#2027) Fine Tuning of Window Bankaccount in WebUI
[#2020](#2020) Add System Configuration Window to WebUI
[#1041](metasfresh/metasfresh-webui-frontend-legacy#1041) included tab: when zoom into the new window opens with error
[#2012](#2012) import messages
[#2013](#2013) Broken Included Tabs to be redone
[#2017](#2017) Create Window Pricing Rule in WebUI
[#1038](metasfresh/metasfresh-webui-frontend-legacy#1038) Flickering effect in Picking Terminal
[#2015](#2015) Create Window Price List Schema in WebUI
[#2009](#2009) Feedback WebUI Prices
[#1009](metasfresh/metasfresh-webui-frontend-legacy#1009) Window Name missing in Action Menu
[#1040](metasfresh/metasfresh-webui-frontend-legacy#1040) Readonly field Contact looks editable
[#2007](#2007) Feedback WebUI CRM
[#1982](#1982) partial issue problem
[#1007](metasfresh/metasfresh-webui-frontend-legacy#1007) eMail Icon in Action Menu
[#999](metasfresh/metasfresh-webui-frontend-legacy#999) grid view: use keyboard + and - to expand/collapse included rows
[#1028](metasfresh/metasfresh-webui-frontend-legacy#1028) Tooltip when hovering GridView Header
[#1015](metasfresh/metasfresh-webui-frontend-legacy#1015) Uncaught TypeError: Cannot read property 'className' of null
[#1029](metasfresh/metasfresh-webui-frontend-legacy#1029) keyboard shortcut and tooltip for button in filters
[#506](metasfresh/metasfresh-webui-api-legacy#506) view: accept included referencing documents when creating a new view
[#1030](metasfresh/metasfresh-webui-frontend-legacy#1030) Directly display quick actions for the first row of a modal window

me-45
@metas-lc metas-lc self-assigned this Aug 7, 2017
@metas-lc
Copy link

metas-lc commented Aug 9, 2017

IT
tested on w101 only
Product Prices opens with no errors OK
(to check: why i don't have this zoom in everywhere)

@teosarca
Copy link
Member Author

teosarca commented Aug 23, 2017

@metas-lc found out why you cannot zoom from price list version (PLV) to product prices.
It's because the M_ProductPrice.M_PriceList_Version_ID column has AllowZoomTo=N.

query used to find out:

select t.TableName, c.ColumnName
from AD_Column c
inner join AD_Table t on (t.AD_Table_ID=c.AD_Table_ID)
where AllowZoomTo='Y'

edit: lc: checked database, it was there "M_ProductPrice";"M_PriceList_Version_ID"

@metas-lc
Copy link

IT
checked again. Still not visible on mf15

@teosarca teosarca self-assigned this Aug 25, 2017
@teosarca
Copy link
Member Author

check again and it seems to work on w101:
image

@teosarca
Copy link
Member Author

teosarca commented Sep 12, 2017

update: found the issue. The AD_Table.AD_Window_ID was wrong on mf15. Just on w101 was correct.

The AD_Table.AD_Window_ID shall be 540325;"Produkt Preise".

Query to check

select AD_Window_ID from AD_Table where TableName='M_ProductPrice'

(from IT: checked: 540325)

@metas-lc
Copy link

IT
window id is 540325 OK
still not visible in zoom in

@metas-lc
Copy link

IT
repeated the testcase above => works fine: you can zoom in
OK

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants