Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Wrong quickActions call when opening HU editor #1078

Closed
teosarca opened this issue Jul 25, 2017 · 2 comments
Closed

Wrong quickActions call when opening HU editor #1078

teosarca opened this issue Jul 25, 2017 · 2 comments

Comments

@teosarca
Copy link
Member

Type of issue

Bug

Current behavior

When the HU editor is opened from receipt candidate, the frontend performs 2 quickActions calls:

  1. one call which is using the viewId=<HU's viewId> but selectedIds=<receipt candidate's id> => the wrong one
  2. one call which is using viewId=<HU's viewId> and selectedIds= => the CORRECT one

Expected behavior

the quickActions call (1) shall not be performed because:

  • it's wrong anyways (the viewId and selectedIds not matching)
  • not needed
  • sometimes the result of that wrong call is displayed in the quickActions button

Steps to reproduce

  • open receipt schedules, e.g. https://w101.metasfresh.com:8443/window/540196
  • select a line where u can receive (i.e. the quick action button will show something like "4 G1 x 10Kg"
  • click on it => the HU editor modal is displayed, the first line is selected but the quickActions are wrong.
    image
@wiadev
Copy link
Contributor

wiadev commented Jul 29, 2017

During fixing story I found that we don't destroy modals when they closed.

Apart of leading to memory consumption it also didn't allowed to re-open the modal in the same view. Not all, but modals with documentList only.

Obviously they're quite heavy leading to quick memory waste.

=> needs to be fixed in #1071

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Jul 31, 2017
[#1052](metasfresh/metasfresh-webui-frontend-legacy#1052) Breadcrumb of "Sales Opportunities" board is incorrectly
[#1078](metasfresh/metasfresh-webui-frontend-legacy#1078) Wrong quickActions call when opening HU editor
[#1094](metasfresh/metasfresh-webui-frontend-legacy#1094) Error on document websocket event
[#1084](metasfresh/metasfresh-webui-frontend-legacy#1084) Handle websocket document stale event

me-45
@metas-lc
Copy link

metas-lc commented Aug 8, 2017

IT
repeated the testcase above and checked the quickactions selectedIDs => the id is the one from HU OK

@metas-lc metas-lc closed this as completed Aug 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants