Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Use user language for messages and errors in Forgot Password feature (frontend) #1958

Closed
teosarca opened this issue Sep 11, 2018 · 3 comments

Comments

@teosarca
Copy link
Member

Is this a bug or feature request?

follow-up of #1878
backend: metasfresh/metasfresh-webui-api-legacy#1038

What is the current behavior?

Which are the steps to reproduce?

  • try to reset your password; click on the URL you got in your email
  • check how the backend is called:
    image

i.e.

  • the GET /availableLanguages is called => at this point we don't know user's language
  • the GET /messages is called => at this point we don't know user's language
  • the GET /resetPassword/{token} is called => now here we are setting session's language using user's language
    .....

What is the expected or desired behavior?

@siemiatj
Copy link
Contributor

This is going to be tricky the way things are laid out now. Translations are the first request, so probably easiest thing to do would be duplicating this request on enter action for reset password views.

@teosarca
Copy link
Member Author

i could live with that....
(talking about requesting again the messages)

@metas-dh
Copy link
Member

metas-dh commented Feb 6, 2019

Results of IT1
tested in release

User language is correcly considered in Forgot Password feature:

  • user had de_DE set: Accept-Language set in Frontend: de_DE: OK
  • user had en_US set: Accept-Language set in Frontend: en_US: OK

@metas-dh metas-dh closed this as completed Feb 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants