Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Uncaught TypeError: Cannot read property 'length' of null at windowHandler (windowHandler.js:395) #2036

Closed
teosarca opened this issue Oct 31, 2018 · 4 comments
Closed

Uncaught TypeError: Cannot read property 'length' of null at windowHandler (windowHandler.js:395) #2036

teosarca opened this issue Oct 31, 2018 · 4 comments
Labels
branch:master branch:release priority:high type:bug

Comments

@teosarca
Copy link
Member

Is this a bug or feature request?

bug
might be related to #2034

What is the current behavior?

Which are the steps to reproduce?

  • open sales orders window
  • open menu, search for some other window and try to open it
Uncaught TypeError: Cannot read property 'length' of null
    at windowHandler (windowHandler.js:395)
    at Array.combination (combineReducers.js:125)
    at eval (index.js:54)
    at dispatch (createStore.js:170)
    at eval (middleware.js:22)
    at eval (index.js:36)
    at eval (index.js:14)
    at Table.componentDidUpdate (Table.js:1162)
    at commitLifeCycles (react-dom.development.js:14693)
    at commitAllLifeCycles (react-dom.development.js:15905)
```
### What is the expected or desired behavior?
shall work
@siemiatj siemiatj self-assigned this Oct 31, 2018
siemiatj added a commit that referenced this issue Oct 31, 2018
@siemiatj
- better error handling #2036
49bede3
@siemiatj siemiatj mentioned this issue Oct 31, 2018
Merged
@teosarca
Copy link
Member Author

quick tested, works

@metas-dh
Copy link
Member

Results of IT1
tested in mf15

  • tested as described above, worked fine: OK
  • went back to sales order window and clicked on 1 row, got
Uncaught TypeError: Cannot read property 'indexOf' of null
    at t.value [as handleClick] (popper.js:25)
    at onClick (popper.js:25)
    at Object.<anonymous> (react-dom.production.min.js:13)
    at f (react-dom.production.min.js:13)
    at react-dom.production.min.js:13
    at T (react-dom.production.min.js:13)
    at O (react-dom.production.min.js:13)
    at S (react-dom.production.min.js:13)
    at E (react-dom.production.min.js:13)
    at P (react-dom.production.min.js:13)
value @ popper.js:25
onClick @ popper.js:25
(anonymous) @ react-dom.production.min.js:13
f @ react-dom.production.min.js:13
(anonymous) @ react-dom.production.min.js:13
T @ react-dom.production.min.js:13
O @ react-dom.production.min.js:13
S @ react-dom.production.min.js:13
E @ react-dom.production.min.js:13
P @ react-dom.production.min.js:13
Ln @ react-dom.production.min.js:13
ma @ react-dom.production.min.js:13
Ne @ react-dom.production.min.js:13
On @ react-dom.production.min.js:13
ba @ react-dom.production.min.js:13
Dn @ react-dom.production.min.js:13

@teosarca @siemiatj is that related or shall i create a new task for that?

siemiatj added a commit that referenced this issue Nov 5, 2018
@siemiatj
- make selected type control tighter #2036
ed32ca9
@siemiatj siemiatj mentioned this issue Nov 5, 2018
Merged
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Nov 5, 2018
@metas-ts
Update ReleaseNotes.md
d0236b8 
[#4690](#4690) Picking Terminal v2: filtering options
[#4691](#4691) Picking Terminal v2: if there is not enough Qty in storage create a new Products To Pick line
[#4703](#4703) Support forum-datenaustausch.ch XML dunning
[#4705](#4705) Avoid SQL N+1 in HU source queries
[#4708](#4708) webui: Change my password does not work
[#4719](#4719) Allow AD_Val_Rule to be auto-applied on new record
[#1094](metasfresh/metasfresh-webui-api-legacy#1094) Login: Show a user friendly error when user or password is empty
[#4732](#4732) Can not create a new order line using 'Add new'
[#1082](metasfresh/metasfresh-webui-api-legacy#1082) Picking from source HU not working
[#1083](metasfresh/metasfresh-webui-api-legacy#1083) QtyPicked in first window picking terminal not correct
[#2018](metasfresh/metasfresh-webui-frontend-legacy#2018) Included view: clicking on it's right side space shall not close the included view
[#2034](metasfresh/metasfresh-webui-frontend-legacy#2034) Uncaught TypeError: selected.indexOf is not a function
[#2036](metasfresh/metasfresh-webui-frontend-legacy#2036) Uncaught TypeError: Cannot read property 'length' of null at windowHandler (windowHandler.js:395)
@siemiatj siemiatj removed their assignment Nov 5, 2018
@metas-ts
Copy link
Member

metas-ts commented Nov 5, 2018

🍒 picked #2036 to release

metas-ts pushed a commit that referenced this issue Nov 5, 2018
@siemiatj @metas-ts
- make selected type control tighter #2036
19061fc 
(cherry picked from commit ed32ca9)
@siemiatj siemiatj mentioned this issue Nov 6, 2018
Closed
@metas-dh
Copy link
Member

metas-dh commented Nov 6, 2018

checked the new case again in weekly e2e: did not happen anymore, worked fine: closing this one.

@metas-dh metas-dh closed this as completed Nov 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
branch:master branch:release priority:high type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@siemiatj @teosarca @metas-ts @metas-dh