Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Edited record is still visible after changing grid page #2370

Closed
siemiatj opened this issue Sep 18, 2019 · 1 comment
Closed

Edited record is still visible after changing grid page #2370

siemiatj opened this issue Sep 18, 2019 · 1 comment
Assignees
@siemiatj
Labels
branch:master branch:release priority:high type:bug

Comments

@siemiatj
Copy link
Contributor

siemiatj commented Sep 18, 2019 •
edited by metas-mk

Is this a bug or feature request?

Bug

What is the current behavior?

  1. right click over number field => edit value
  2. put any value
  3. got to next page
  4. NOK: record stays although we are on next page
    fsNMIsnIG9

Which are the steps to reproduce?

see behavior

What is the expected or desired behavior?

Remove the edited record and use whatever comes with data
@siemiatj siemiatj self-assigned this Sep 18, 2019
@siemiatj siemiatj mentioned this issue Sep 18, 2019
Merged
siemiatj added a commit that referenced this issue Sep 18, 2019
@siemiatj
#2370 simple fix
4223369
siemiatj added a commit that referenced this issue Sep 18, 2019
@siemiatj
#2370 nicer solution, variable controlled
d3ec468
metas-ts pushed a commit that referenced this issue Sep 20, 2019
@siemiatj @metas-ts
#2370 simple fix
42784bd 
(cherry picked from commit 4223369)
metas-ts pushed a commit that referenced this issue Sep 20, 2019
@siemiatj @metas-ts
#2370 nicer solution, variable controlled
69c7466 
(cherry picked from commit d3ec468)
metas-ts pushed a commit that referenced this issue Sep 20, 2019
@siemiatj @metas-ts
#2370 simple fix
1505448 
(cherry picked from commit 4223369)
metas-ts pushed a commit that referenced this issue Sep 20, 2019
@siemiatj @metas-ts
#2370 nicer solution, variable controlled
ccc4a42 
(cherry picked from commit d3ec468)
metas-ts pushed a commit that referenced this issue Sep 20, 2019
@siemiatj @metas-ts
#2370 simple fix
a90ec9f 
(cherry picked from commit 4223369)
metas-ts pushed a commit that referenced this issue Sep 20, 2019
@siemiatj @metas-ts
#2370 nicer solution, variable controlled
35f8ac2 
(cherry picked from commit d3ec468)
metas-ts pushed a commit that referenced this issue Sep 20, 2019
@siemiatj @metas-ts
#2370 simple fix
d76d6bb 
(cherry picked from commit 4223369)
metas-ts pushed a commit that referenced this issue Sep 20, 2019
@siemiatj @metas-ts
#2370 nicer solution, variable controlled
433a85b 
(cherry picked from commit d3ec468)
metas-ts pushed a commit that referenced this issue Sep 20, 2019
@siemiatj @metas-ts
#2370 simple fix
2400af2 
(cherry picked from commit 4223369)
metas-ts pushed a commit that referenced this issue Sep 20, 2019
@siemiatj @metas-ts
#2370 nicer solution, variable controlled
fd13606 
(cherry picked from commit d3ec468)
@siemiatj siemiatj reopened this Oct 10, 2019
@siemiatj
Copy link
Contributor Author

The previous solution impacted the performance too much, so we need a better way to solve this

siemiatj added a commit that referenced this issue Oct 11, 2019
@siemiatj
#2370 rewrite watcher over table selection changes
2f1442f 
#2370 update object-hash package
siemiatj added a commit that referenced this issue Oct 11, 2019
@siemiatj
#2370 remove lots of unnecessary anonymous functions that trigger pro…
7c6cfc0 
…ps update and re-renders
siemiatj added a commit that referenced this issue Oct 11, 2019
@siemiatj
#2370 don't pass widgetData as prop as it triggers unnecessary re-ren…
c2838f3 
…ders
@siemiatj siemiatj mentioned this issue Oct 11, 2019
Merged
siemiatj added a commit that referenced this issue Oct 14, 2019
@siemiatj
#2370 properly get widgetData in TableCell
5e2adc2
siemiatj added a commit that referenced this issue Oct 14, 2019
@siemiatj
#2370 use v4 hash for tracking data changes
f5578a8
siemiatj added a commit that referenced this issue Oct 14, 2019
@siemiatj
#2370 rewrite watcher over table selection changes
96f03b5 
#2370 update object-hash package
siemiatj added a commit that referenced this issue Oct 14, 2019
@siemiatj
#2370 remove lots of unnecessary anonymous functions that trigger pro…
9cf0c0d 
…ps update and re-renders
siemiatj added a commit that referenced this issue Oct 14, 2019
@siemiatj
#2370 don't pass widgetData as prop as it triggers unnecessary re-ren…
49eed14 
…ders
siemiatj added a commit that referenced this issue Oct 14, 2019
@siemiatj
#2370 properly get widgetData in TableCell
2d15897
siemiatj added a commit that referenced this issue Oct 14, 2019
@siemiatj
#2370 use v4 hash for tracking data changes
ceb5502
siemiatj added a commit that referenced this issue Oct 14, 2019
@siemiatj
#2370 fix prop types
bcdc62c
siemiatj added a commit that referenced this issue Oct 14, 2019
@siemiatj
#2370 fix updating field value
c8e966d
siemiatj added a commit that referenced this issue Oct 14, 2019
@siemiatj
- #2370 remove weird return type for widget data
3e7b6bd
siemiatj added a commit that referenced this issue Oct 14, 2019
@siemiatj
#2370 fix lint errors
67da759
siemiatj added a commit that referenced this issue Oct 15, 2019
@siemiatj
#2370 remove the old weird quirk where we were setting widgetValue to…
6b50efb 
… null
metas-mk added a commit to metasfresh/metasfresh that referenced this issue Oct 15, 2019
@metas-mk
Update ReleaseNotes.md
dd7e622 
Adds new issue
metasfresh/metasfresh-webui-frontend-legacy#2370
Performance imporovement for Grid Views/ Table Views
metas-ts pushed a commit that referenced this issue Oct 18, 2019
@siemiatj @metas-ts
#2370 simple fix
1eef32b 
(cherry picked from commit 4223369)
metas-ts pushed a commit that referenced this issue Oct 18, 2019
@siemiatj @metas-ts
#2370 nicer solution, variable controlled
4f17630 
(cherry picked from commit d3ec468)
siemiatj added a commit that referenced this issue Oct 18, 2019
@siemiatj
#2370 rewrite watcher over table selection changes
b230b71 
#2370 update object-hash package
siemiatj added a commit that referenced this issue Oct 18, 2019
@siemiatj
#2370 remove lots of unnecessary anonymous functions that trigger pro…
2c185c4 
…ps update and re-renders
siemiatj added a commit that referenced this issue Oct 18, 2019
@siemiatj
#2370 don't pass widgetData as prop as it triggers unnecessary re-ren…
428968d 
…ders
siemiatj added a commit that referenced this issue Oct 18, 2019
@siemiatj
#2370 use v4 hash for tracking data changes
9bdf8dd
siemiatj added a commit that referenced this issue Oct 18, 2019
@siemiatj
#2370 fix prop types
53cc17d
siemiatj added a commit that referenced this issue Oct 18, 2019
@siemiatj
#2370 fix updating field value
98c94b5
siemiatj added a commit that referenced this issue Oct 18, 2019
@siemiatj
- #2370 remove weird return type for widget data
984a034
siemiatj added a commit that referenced this issue Oct 18, 2019
@siemiatj
#2370 fix lint errors
a54b270
siemiatj added a commit that referenced this issue Oct 18, 2019
@siemiatj
#2370 remove the old weird quirk where we were setting widgetValue to…
e161903 
… null
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@siemiatj siemiatj

Labels
branch:master branch:release priority:high type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@siemiatj @metas-ts @metas-mk