Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

view websocket notifications: handle "changedIds" #355

Closed
teosarca opened this issue Feb 19, 2017 · 5 comments
Closed

view websocket notifications: handle "changedIds" #355

teosarca opened this issue Feb 19, 2017 · 5 comments
Assignees
@damianprzygodzki @metas-lc
Labels
branch:master branch:release type:enhancement
Milestone
2017-16

Comments

@teosarca
Copy link
Member

NOTE: this is a follow-up of #211

We introduced new property to the JSON event called "changedIds". When set, contains an array of document IDs which changed in the grid view.

When frontend gets that array it shall refresh ONLY those rows which are identified by provided IDs.
If the rows are not present in current page, the frontend shall do nothing.

To easily fetch only some rows from backend we introduced following REST API: http://w101.metasfresh.com:8081/swagger-ui.html#!/document-view-rest-controller/getByIdsUsingGET

Test case (where are are already using this feature): metasfresh/metasfresh-webui-api-legacy#150 , i.e.

  • open Material Receipt Candidates
  • Receive some HUs (create material receipt for those too!)
  • back in Material Receipt Candidates, QtyMoved changed shall be updated.
@teosarca teosarca added this to the 2017-09 milestone Feb 19, 2017
This was referenced Feb 19, 2017
Closed
Closed
@damianprzygodzki damianprzygodzki self-assigned this Feb 24, 2017
@teosarca
Copy link
Member Author

Blocks metasfresh/metasfresh-webui-api-legacy#152

@metas-mk metas-mk modified the milestones: 2017-12, 2017-09 Mar 6, 2017
@cadavre cadavre modified the milestones: 2017-13, 2017-12 Mar 21, 2017
@damianprzygodzki
Copy link
Contributor

damianprzygodzki commented Mar 24, 2017 •
edited
Loading

I can't find out how to fetch data from that endpoint.

This is what Swagger says:

screen shot 2017-03-24 at 07 25 18
screen shot 2017-03-24 at 07 25 29
(The ids parameter is lost)
screen shot 2017-03-24 at 07 25 36
And API missing it too.

But, even if i add this parameter:
screen shot 2017-03-24 at 07 25 44
The ids is missing.
screen shot 2017-03-24 at 07 25 58

damianprzygodzki added a commit that referenced this issue Mar 24, 2017
@damianprzygodzki
#355 changedIds ws event's parameter handling (wip)
294e74e
teosarca added a commit to metasfresh/metasfresh-webui-api-legacy that referenced this issue Mar 26, 2017
@teosarca
#150 FIX DocumentViewRestController.getByIds ids param
b0bc638 
issue reported on
metasfresh/metasfresh-webui-frontend-legacy#355 (comment)
@teosarca
Copy link
Member Author

note: shall be fixed on next rollout

@metas-mk metas-mk modified the milestones: 2017-16, 2017-13 Apr 5, 2017
damianprzygodzki added a commit that referenced this issue Apr 20, 2017
@damianprzygodzki
#355 ChangedIds model update
10a4e04
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Apr 21, 2017
@metas-ts
[#303](metasfresh/metasfresh-webui-api-legacy#303) ASI button not wor…
002c9ca 
…king from process panel

[#1351](#1351) IsTransferWhenNull not working correctly anymore
[#661](metasfresh/metasfresh-webui-frontend-legacy#661) Service not available not detected on login
[#659](metasfresh/metasfresh-webui-frontend-legacy#659) Double-clicking on included view row shall not open the document
[#657](metasfresh/metasfresh-webui-frontend-legacy#657) Manufacturing Order Issue/Receipt is not displaying the attributes
[#1346](#1346) Cannot "LU zuteilen" (Swing HU Editor)
[#656](metasfresh/metasfresh-webui-frontend-legacy#656) Selected grid row and quick actions not consistent after closing a modal
[#1343](#1343) Cannot reverse documents
[#655](metasfresh/metasfresh-webui-frontend-legacy#655) Handle process layout type field
[#653](metasfresh/metasfresh-webui-frontend-legacy#653) Honor openIncludedView's viewType property
[#645](metasfresh/metasfresh-webui-frontend-legacy#645) HOME/END keys not working in process parameter field when opened from view
[#643](metasfresh/metasfresh-webui-frontend-legacy#643) Reduce size of Action Menu
[#630](metasfresh/metasfresh-webui-frontend-legacy#630) Open docLists side by side in QuickAction response.
[#355](metasfresh/metasfresh-webui-frontend-legacy#355) view websocket notifications: handle "changedIds"
[#96](metasfresh/metasfresh-webui-frontend-legacy#96) Actions overlay menu cleanup
@teosarca
Copy link
Member Author

Note to IT: test together with metasfresh/metasfresh-webui-api-legacy#151 (comment) . Use the test cases from there.

@metas-lc metas-lc self-assigned this Apr 26, 2017
@metas-lc
Copy link

tested in metasfresh/metasfresh-webui-api-legacy#151

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@damianprzygodzki damianprzygodzki

@metas-lc metas-lc

Labels
branch:master branch:release type:enhancement
Projects
None yet
Milestone
2017-16
Development

No branches or pull requests
6 participants
@cadavre @teosarca @metas-ts @damianprzygodzki @metas-mk @metas-lc