Improved Not Saved Indicator design

[metas-mk]

Type of issue

Feature request

Current behavior

The "Not saved indicator" is a tiny little bit suboptimal.

Expected behavior

Have an improved design of the "Not Saved indicator"

Now it looks like:

What it should look like:

... or something similar to that.

[metas-mk]

This is a follow up task for #437

[metas-mk]

@damianprzygodzki
Just checked quickly. Already looks much better. Is it easy possible to make that red line "permanently" visible as soon as not saved and those "error" fields are shown in red color? As soon as the gray-green bar can kick in and vanish the red.

[damianprzygodzki]

@metas-mk Do You mean, if document has saveStatus false, we are disabling loader and instead of it we are displaying fully filled red bar ?

[metas-mk]

Fully filled 1px line in red (same dimension as thin gray line atm). The green and gray motion shall still remain for each save progress. But if is then unsaved because of error os missing field content (like in example above) then show that filled red line after saving progress indicator (grey-green).

Pls let me know if we shall quickly talk about this to do a quick demo in advance.

[damianprzygodzki]

Roger

[cadavre]

+1 for 1px line coloured if saveStatus=false. BUT I would propose to resign from color red. Red suggests error which is NOT the case here. I propose to use "yellow" color which stands for "warning" instead of "error". Wdyt?

After saveStatus=true fade 1px line color to regular gray.

[metas-mk]

just suggested red because it would only appear when the user also sees the red error fields ... to not be confused w/ 2-3 different colors

[cadavre]

Shown after first validation then? Sounds ok.

[metas-mk]

yes

[damianprzygodzki]

It is unreachable because PATCHes are not updating validStatus.initialValue. So i can't turn indicator red after first patch.

What can i do without API changes is to make red background under indicator (it will be still indicating state of saving) til the saved property will change.

[teosarca]

hi @damianprzygodzki

I think you have all informations.

Take a look at following use case and pls let me know if you still believe something is missing.

1. New sales order
   

2. Fill the bpartner field => expect document to be saved
   

3. Clear the BPartner field
   

[damianprzygodzki]

Case:

• new sales order
• checking a checkbox
• initialValue for whole documents not changed
• mandatory fields not filled, indicator bar is still green

Whatsmore, in the 2nd step, initialValue should be false.

[teosarca]

@damianprzygodzki Mark and I just checked after your last commit.
Works as expected.

[teosarca]

thanks a lot !

[metas-mk]

Tested. Works as required. Thanks a lot. Closing.