Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Icons for manufacturing components #675

Closed
metas-mk opened this issue Apr 24, 2017 · 15 comments
Closed

Icons for manufacturing components #675

metas-mk opened this issue Apr 24, 2017 · 15 comments
Assignees
@damianprzygodzki @metas-lc
Labels
branch:master branch:release type:enhancement
Milestone
2017-17

Comments

@metas-mk
Copy link
Member

Type of issue

Feature request

Current behavior

Currently, the icons for receive/ issue products in manufacturing UI has the "Palette" Symbol as a placeholder.

Expected behavior

The receive lines shall have one icon, the issue lines shall have another.
Idea: For receive lines have an icon w/ arrow up/ arrow right. For issue lines have arrow down/ arrow left?
@metas-mk metas-mk added this to the 2017-17 milestone Apr 24, 2017
@metas-mk metas-mk changed the title Icons for manufacturing componentes Icons for manufacturing components Apr 24, 2017
@damianprzygodzki damianprzygodzki self-assigned this Apr 25, 2017
@damianprzygodzki
Copy link
Contributor

@cadavre waiting for icons.

@teosarca
Copy link
Member

NOTE: When fetching the lines, the "type" field will be filled as:

  • "PP_Order_Receive" - receive line
  • "PP_Order_Issue" - issue line
  • or any of the HU icons: "LU", "TU", "CU"

teosarca added a commit to metasfresh/metasfresh-webui-api-legacy that referenced this issue Apr 25, 2017
@teosarca
set PPOrderLine icons
b2e7906 
as described on
metasfresh/metasfresh-webui-frontend-legacy#675 (comment)
damianprzygodzki added a commit that referenced this issue Apr 25, 2017
@damianprzygodzki
#675 New icons for indendation
b23bdd1
@damianprzygodzki
Copy link
Contributor

damianprzygodzki commented Apr 27, 2017 •
edited
Loading

Good morning @metas-mk ,
the new icons for received and issued products were complicating our icon set. They were too rectangular, and we are proposing the new version of them, to keep the icons consistent.
Could You make a review before merging?
screen shot 2017-04-27 at 14 09 14 screen shot 2017-04-27 at 14 09 11

damianprzygodzki added a commit that referenced this issue Apr 28, 2017
@damianprzygodzki
Merge pull request #687 from metasfresh/dev-675
36543fa 
#675 New icons for indendation
@metas-mk
Copy link
Member Author

@damianprzygodzki thanks. please integrate those so we can see live in webui. we can check then if it's looking ok in screen.

@metas-mk
Copy link
Member Author

metas-mk commented Apr 28, 2017 •
edited
Loading

@damianprzygodzki checked. does not look&feel good. Icons are too small and feel smaller than the Handling Unit icons.
If the icons shall be square ratio I suggest to have Icons that show the meaning in square shape.
what about for action_receipt have something like an assembly icon (something in this direction):
image
and for action_issue have something like this:
image

image

damianprzygodzki added a commit that referenced this issue Apr 28, 2017
@damianprzygodzki
#675 New icons #2
d7ceb50
@metas-lc metas-lc self-assigned this May 2, 2017
@metas-lc
Copy link

metas-lc commented May 3, 2017

IT
bigger but still not visible enough. NOK

metas-ts added a commit to metasfresh/metasfresh that referenced this issue May 5, 2017
@metas-ts
complement the ReleaseNotes.md
0e95724 
[#702](metasfresh/metasfresh-webui-frontend-legacy#702) Running a process from menu does not work, again
[#342](metasfresh/metasfresh-webui-api-legacy#342) Exception in WebUI when opening initial Doc Outbound window
[#886](#866) Make payment callouts work in webui
[#341](metasfresh/metasfresh-webui-api-legacy#341) Apply role permissions when browsing/editing data
[#340](metasfresh/metasfresh-webui-api-legacy#340) Manufacturing order: Prevent issuing VHUs which are not top level
[#700](metasfresh/metasfresh-webui-frontend-legacy#700) Typeahead not working in lookup filter parameters
[#1435](#1435) Add method for Escaping '@' char, by replacing one @ with double @@
[#330](metasfresh/metasfresh-webui-api-legacy#330) Implement webui HUEditor support for massive amount of HUs
[#1315](#1315) 2D Barcode wit ad_table_id/ record_id on bestellkontrolle
[#675](metasfresh/metasfresh-webui-frontend-legacy#675) Icons for manufacturing components
[#334](metasfresh/metasfresh-webui-api-legacy#334) switch filters to primary layout
[#697](metasfresh/metasfresh-webui-frontend-legacy#697) New Businesspartner modal overlay cancel
[#257](metasfresh/metasfresh-webui-api-legacy#257) BPartner contact cannot be saved because mandatory field Name is not set

me-45
@damianprzygodzki
Copy link
Contributor

damianprzygodzki commented May 8, 2017 •
edited
Loading

@metas-lc Are you using the up to date version?

And second thing, what is not visible enough? For now we have the same size of icons for MP as for TU. What is the expected size/solution?

screen shot 2017-05-08 at 10 40 32

@teosarca
Copy link
Member

teosarca commented May 9, 2017

quick checked now on w101 and it looks like in the screenshot that i've attached.

@metas-lc pls check again

image

@teosarca
Copy link
Member

update: as discussed yesterday, pls provide the cogs-ish icons.

@cadavre
Copy link
Contributor

cadavre commented May 10, 2017 •
edited
Loading

In today's worklane for our gfx.

@teosarca
Copy link
Member

update: for future reference, i am adding here the meaning of those 2 icons, as Mark described them.

  • receipt - action : processing action. result of this action is the produced good. people have to do something to achieve this.

  • issue - action : adding raw materials to the manufacturing process. it's about consuming raw materials and add them to the manufacturing process.

@cadavre
Copy link
Contributor

cadavre commented May 10, 2017

icons

Third and second from last are receipt and issue icons.

Quote from gfx design:

One and three cogs – to differentiate it from "settings" icon they were made in plane style instead of linear style. There's also no hole in the cogs so it means more "process" than the cog itself.

@damianprzygodzki
Copy link
Contributor

Are we waiting for an accept, or integrating this icon set?

@teosarca
Copy link
Member

please integrate them asap.

teosarca referenced this issue May 13, 2017
@damianprzygodzki
New icon set
f3cb925
@metas-lc
Copy link

IT
icons are changed OK

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@damianprzygodzki damianprzygodzki

@metas-lc metas-lc

Labels
branch:master branch:release type:enhancement
Projects
None yet
Milestone
2017-17
Development

No branches or pull requests
6 participants
@cadavre @teosarca @metas-ts @damianprzygodzki @metas-mk @metas-lc