Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Filter singleOverlayField support #742

Closed
teosarca opened this issue May 13, 2017 · 6 comments
Closed

Filter singleOverlayField support #742

teosarca opened this issue May 13, 2017 · 6 comments

Comments

@teosarca
Copy link
Member

Type of issue

Feature request

Expected behavior

When fetching the view layout, so the filter layouts too, if a filter has "parametersLayoutType":"singleOverlayField" then when user clicks on that filter it shall be rendered like the process parameters with "parametersLayoutType":"singleOverlayField" (see task #655 ).
It shall look like:
image

When the user presses enter, the filter shall be applied.
When the user cancels (e.g. presses ESC) the filter shall be cleared.

Steps to reproduce

image

Required for metasfresh/metasfresh-webui-api-legacy#364

@Dunkat
Copy link
Contributor

Dunkat commented May 15, 2017

for clearing filter used 'delete'. For closing overlay used 'Esc'

damianprzygodzki added a commit that referenced this issue May 15, 2017
Filter singleOverlayField support #742
@teosarca
Copy link
Member Author

As talked on skype

  • when user clears the Barcode field => frontend shall automatically remove the Barcode filter
  • when the Barcode is opened, automatically select the text

@cadavre
Copy link
Contributor

cadavre commented May 16, 2017

To be precise:

when user clears the Barcode field => frontend shall automatically remove the Barcode filter

when user clears the Barcode field and press [Enter] => frontend shall automatically remove the Barcode filter

@Dunkat
Copy link
Contributor

Dunkat commented May 16, 2017

should I leave clearing filter on 'delete' key or remove it?

Dunkat added a commit that referenced this issue May 16, 2017
@cadavre
Copy link
Contributor

cadavre commented May 16, 2017

I would say no, because someone might want to change single digit with [Del] as same as with [Backspace].

damianprzygodzki added a commit that referenced this issue May 17, 2017
Clear singleOverlay filter when user set empty value #742
damianprzygodzki added a commit that referenced this issue May 17, 2017
Remove delete shortcut for clearing filter #742
@metas-lc metas-lc self-assigned this May 18, 2017
@metas-lc
Copy link

IT

  1. open window/540189
  2. Click Filters -> Barcode
    2.1 write something then press esc => filter NOT applied OK
    2.2 write something , remove what you wrote and press enter => filter NOT applied OK
    2.3 press enter directly => filter NOT applied OK
    2.4 write something and press delete => nothing happens, but you can use delete to remove what you wrote OK
    2.5 write the value of an existing TU (from that page or another) => your HU is filtered OK
    2.6 write something that doesn't exists => no results OK

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants