Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Loading of empty delivery Days Window take long #847

Closed
metas-mk opened this issue Jun 7, 2017 · 9 comments
Closed

Loading of empty delivery Days Window take long #847

metas-mk opened this issue Jun 7, 2017 · 9 comments

Comments

@metas-mk
Copy link
Member

metas-mk commented Jun 7, 2017

Type of issue

Feature request

Current behavior

Currently, the first opening and reload after refresh takes very long for window/540110 delivery days. Also when refreshing/ reloading it shows weird behavior.

Expected behavior

Something that is better for the user. Let's discuss ;-)

image

@cadavre
Copy link
Contributor

cadavre commented Jun 7, 2017

It is pure backend time (12.30s) which frontend is waiting to get response. Only thing frontend can do is to add some spinner, maybe with "Loading data..." text, into container of GridView. I'll need more feedback from @damianprzygodzki how can we achieve this and how to make it in generic way.

@cadavre cadavre modified the milestones: 2017-25, 2017-24 Jun 7, 2017
@teosarca
Copy link
Member

teosarca commented Jun 7, 2017

@cadavre True, that would be the best.
But also, observe that after refresh, not even the layout is shown until the data is fetched,
So frontend should always show the layout ASAP.

Remark that on first time when i am loading it, it works exactly how it's needed. Layout is displayed ASAP. And when data is available, the rows are displayed.

@damianprzygodzki
Copy link
Contributor

damianprzygodzki commented Jun 8, 2017

@cadavre I think that the best thing to do for gridview without data is to add some initial text in place of "There are no detail rows" something like "Loading the data...".

@teosarca The case is that for performance issue we allow to show only gridview, when and data and layout are ready to do not re-render whole view few times due to component dependencies in data (QuickActions, Table (size, orderBy, queryHitLimit etc)). We can remove that, but it is change in assumption, may cause lot of problems, so refactor and performance research needed. We should postpone that (move to the farthest milestone we can).

@teosarca
Copy link
Member

teosarca commented Jun 8, 2017

Hi @damianprzygodzki

IMHO, the frontend shall be as fluent as possible.
The case of "when loading the data the endpoint fails" it's an exception and we shall not optimize for that.
Usually, "retrieving the data" works without any error.

More, atm, the behaviour is not consistent.

Case 1: Here is how it looks when the view is loaded first time, i.e. you can see it by clicking on https://w101.metasfresh.com:8443/window/540110

image

Case 2: Here is how it looks when i am refreshing the page

image

@damianprzygodzki
Copy link
Contributor

damianprzygodzki commented Jun 8, 2017

IMHO, the frontend shall be as fluent as possible.

Fluent with bad performance is impossible :)

The case of "when loading the data the endpoint fails" it's an exception and we shall not optimize for that.

We do not optimize for that. I've said already about the reason:

to do not re-render whole view few times due to component dependencies

And in reference to other screeshots. I am aware about all that things. And i can just copy and paste my last message.

We can remove that (...) may cause lot of problems. (...) We should postpone that (move to the farthest milestone we can).

@teosarca
Copy link
Member

teosarca commented Jun 8, 2017

ok, let's talk when u have time because to be honest I don't understand

@cadavre
Copy link
Contributor

cadavre commented Jun 8, 2017

We found out that this is caused by already generated viewId that is being used (12s) instead of empty placeholder API call (50ms) which returned meta-data that is required in frontend.

On call we made assumption to make "Minimum Viable Solution" to solve this for now:

  1. If it is possible and won't make top loading bar flickering – add loader bar for each API call made.

  2. But if it will make this loading bar flicker in unwanted way – we add loader bar moving additionally only for loading data in gridview.

With no.1 we're waiting for @damianprzygodzki to make a live preview or screen movie or GIF showing how it works and judge if it's flickering or not.

Reminder: this is not high priority.

damianprzygodzki added a commit that referenced this issue Jun 9, 2017
damianprzygodzki added a commit that referenced this issue Jun 9, 2017
@teosarca
Copy link
Member

teosarca commented Jun 9, 2017

btw, i am taking out status:in-discussion because it's no longer in discussion.

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Jun 14, 2017
[#878](metasfresh/metasfresh-webui-frontend-legacy#878) Error firework when logout
[#880](metasfresh/metasfresh-webui-frontend-legacy#880) Change Icon for URL Link
[#881](metasfresh/metasfresh-webui-frontend-legacy#881) Error when pressing Action Menu in Collapsible Grid Window
[#883](metasfresh/metasfresh-webui-frontend-legacy#883) hu editor doesn't update
[#451](metasfresh/metasfresh-webui-api-legacy#451) Provide view sticky filters to be displayed by frontend
[#456](metasfresh/metasfresh-webui-api-legacy#456) Outbound Mail endpoint prototype
[#1807](#1807) Fix "Create primary key" process
[#879](metasfresh/metasfresh-webui-frontend-legacy#879) Avatar Picture not deleted from Header when cleared in Profile Settings
[#1802](#1802) picking terminal is not opening
[#436](metasfresh/metasfresh-webui-api-legacy#436) Manufacturing Order Issue not possible after barcode filtering
[#453](metasfresh/metasfresh-webui-api-legacy#453) Password process parameters shall allow showing the password
[#849](metasfresh/metasfresh-webui-frontend-legacy#849) manufacturing order doesn't open
[#437](metasfresh/metasfresh-webui-api-legacy#437) Load/ Reload of delivery Days window takes too long.
[#446](metasfresh/metasfresh-webui-api-legacy#446) Cannot open the menu when logged in as System Administrator
[#433](metasfresh/metasfresh-webui-api-legacy#433) Show Manufacturing Order number in window header
[#1793](#1793) fix jasper document for vendor returns
[#848](metasfresh/metasfresh-webui-frontend-legacy#848) notifications don't update
[#400](metasfresh/metasfresh-webui-api-legacy#400) minimum password length error message not displayed
[#444](metasfresh/metasfresh-webui-api-legacy#444) Make Dashboard Translatable
[#447](metasfresh/metasfresh-webui-api-legacy#447) Truncate WEBUI_ViewSelection tables on startup
[#847](metasfresh/metasfresh-webui-frontend-legacy#847) Loading of empty delivery Days Window take long
[#1735](#1735) istransferwhennull not working in webUI but in java client
[#1748](#1748) Project Documentation: Screenshots
[#795](metasfresh/metasfresh-webui-frontend-legacy#795) On tab stale event, don't refresh tabs which are queryOnLoad but are not the active tab

me-45
@metas-rc
Copy link
Member

Results of IT

Tested on webui

Opening Liefertage (Delivery Days) window (540110) happens immediately => OK

@metas-rc metas-rc self-assigned this Jun 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants