Use the Provided Endpoint w/ entry selections for given Breadcrumb

[metas-rc]

Type of issue

Bug

Current behavior

Endpoint provided by the API is not used.

Expected behavior

It shall be used so we don't have to modify the frontend in future, if we want to modify the breadcrumb logic.

Steps to reproduce

• Inspect the breadcrumb while clicking on nodes in menu

• NOK: The whole tree is provided instead of the node you selected.

• Backend counterpart: Provide Endpoint w/ entry selections for given Breadcrumb metasfresh-webui-api-legacy#465

• It should have been fixed in : Improvement of Breadcrumb Navigation Dropdown entries #920

[teosarca]

i.e. use http://w101.metasfresh.com:8081/swagger-ui.html#!/menu-rest-controller/getNodeBreadcrumbMenuUsingGET

[metas-ts]

it's now rolled out on our IT instance, but not yet integrated into master

[metas-lc]

IT (not master)
go to a window (e.g. Product) and select the breadcrumb. See inspection => only the nodes from the breadcrumb menu are shown OK

[metas-lc]

found this issue. That breadcrumb should only go back to sales orders (back to gridview)

[metas-mk]

error belongs to this issue #1008
task chat started there. please move both when solved.

[teosarca]

and more, when the grid view is loaded the breadcrumb endpoint is called for each menu item.
That's not efficient at all because might be that user will never click on those items.

[cadavre]

Also #1009 is caused by this change.

[wiadev]

getWindowBreadcrumb called twice in two different components. These calls are chronologically very close each to other and simply first requests are not resolved at a moment, thus results not cached. And after this is fires second time. This doesn't happens every single refresh, but happens pretty often.
fixes are in dev-979

[metas-rc]

Results of IT

Tested on webui.

Opened the window Product from the Whole Tree.

When I opened it, the breadcrumb for Product Management was already loaded, and displayed in the inspection. => NOK

When I clicked on the Product Management, nothing appeared in inspection => NOK

Please, check Teo's comment above:

and more, when the grid view is loaded the breadcrumb endpoint is called for each menu item.
That's not efficient at all because might be that user will never click on those items.

[wiadev]

Probably this could be optimized even further.

We have type=group for breacrumb path request. Which means that those items have dropdown, while type=window means that no dropdown items are defined, so no need even to try to load empty list of sub-items.

But for dropdowns (e.g. type=group) we must send request to get sub-items.
Yes, it could be attached to click event, but obviously it will add some small delay (for me now it shows some 75-150 msecs) and then rendering of menu.

[metas-ts]

cherry-picked commit 668efa2 into the release branch

[metas-lc]

IT

1. breadcrumbMenu appears only when you select the breadcrumb for menu (e.g. Product management) OK
2. breadcrumb for "go to default document list" goes back to gridview (or if you are already there only refresh) OK
3. when you select the breadcrumb for menu (e.g. Product management) you can see a small delay until it gets populated. Have to check if i shall create a new task and how it should work

Edit: it's OK for now. Closing the issue