Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

fix(Filter): keep track of active filters #1087

Closed
wants to merge 2 commits into from
Closed

fix(Filter): keep track of active filters #1087

wants to merge 2 commits into from

Conversation

vko-online
Copy link

@vko-online vko-online commented Jul 26, 2017

Problem: filters stored as objects, they override each other every time 1 filter changes
Solution: Keep track of every filter separate, using single uniq key identifier

task: #1021

@teosarca
Copy link
Member

Did a quick test but now nothing happens when i press apply (i.e. nothing sent to backend):
image

image

@vko-online
Copy link
Author

@teosarca Yes, sorry, my bad, now i've reverted the initial state value. Works as expected now

@metasnw
Copy link
Member

metasnw commented Jul 26, 2017

after testing the filters are applied but are not displayed correctly.
@teosarca shall we close the PR ?

@teosarca
Copy link
Member

@metasnw yup. basically the frontend was sending the right filters to backend but after that, in UI, the filters were cleared and just the last one used was kept.

@teosarca teosarca closed this Jul 27, 2017
@teosarca teosarca deleted the gh1021 branch July 27, 2017 11:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants