Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

window actions shall respect the "disabled" flag #1294

Closed
teosarca opened this issue Oct 23, 2017 · 5 comments
Closed

window actions shall respect the "disabled" flag #1294

teosarca opened this issue Oct 23, 2017 · 5 comments

Comments

@teosarca
Copy link
Member

Is this a bug or feature request?

FR

What is the current behavior?

When calling for window actions (e.g. http://w101.metasfresh.com:8081/swagger-ui.html#!/window-rest-controller/getDocumentActionsUsingGET_1 ),
the "disabled" flag is not respected.

Which are the steps to reproduce?

check for example

What is the expected or desired behavior?

if an action is disabled,

  • it shall be grayed out
  • the disabledReason (if available) shall be displayed beneath

image

@teosarca
Copy link
Member Author

teosarca commented Oct 23, 2017

note to dev: it might be that the disabled processes are not returned by /actions endpoint.
See metasfresh/metasfresh-webui-api-legacy#644

update: document /actions endpoints have "disabled" parameter.

@ottosichert
Copy link
Contributor

@teosarca I saw your comment on metasfresh/metasfresh-webui-api-legacy#644 (comment) and it confused me a little bit.

In the view https://w101.metasfresh.com:8443/window/143/<insert_id> there are no actions with a disabled and disabledReason property as you stated in your comment that these actions will not be returned at all.

Are there any views left with disabled actions?

@teosarca
Copy link
Member Author

@ottosichert yes they are, but u need to call the /actions endpoint using disabled=true param, which advises the API to return the disabled actions too...
e.g.
http://w101.metasfresh.com:8081/rest/api/window/143/1000139/actions?disabled=true

@ottosichert
Copy link
Contributor

Okay now I understand your comment I mentioned.

I added it in ad6dd2d to #1305

@metas-dh
Copy link
Member

Results of IT1
tested in mf15

  • disabled action is grayed out: OK
  • the disabledReason (if available) is displayed beneath: OK

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Nov 5, 2017
[#652](metasfresh/metasfresh-webui-api-legacy#652) Implement document discardChanges endpoint
[#1294](metasfresh/metasfresh-webui-frontend-legacy#1294) window actions shall respect the "disabled" flag
[#650](metasfresh/metasfresh-webui-api-legacy#650) flatrate contractstatus not refresh in single view after terminated
[#2859](#2859) Pre-enddate termination of flatrate created compensation sales order
[#2854](#2854) Save Termination Reason when terminating subscription
[#2676](#2676) flatrate: make subscription progress reflecting progress

me-45
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Nov 5, 2017
[#652](metasfresh/metasfresh-webui-api-legacy#652) Implement document discardChanges endpoint
[#1294](metasfresh/metasfresh-webui-frontend-legacy#1294) window actions shall respect the "disabled" flag
[#650](metasfresh/metasfresh-webui-api-legacy#650) flatrate contractstatus not refresh in single view after terminated
[#2859](#2859) Pre-enddate termination of flatrate created compensation sales order
[#2854](#2854) Save Termination Reason when terminating subscription
[#2676](#2676) flatrate: make subscription progress reflecting progress

me-45

(cherry picked from commit 76900a8)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants