Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement document discardChanges endpoint #652

Closed
teosarca opened this issue Oct 30, 2017 · 1 comment
Closed

Implement document discardChanges endpoint #652

teosarca opened this issue Oct 30, 2017 · 1 comment
Assignees
@metas-lc
Labels
branch:master branch:release type:enhancement

Comments

@teosarca
Copy link
Member

Is this a bug or feature request?

FR

What is the expected or desired behavior?

Have 2 endpoints:

  • POST /{windowId}/{documentId}/discardChanges
  • POST /{windowId}/{documentId}/{tabId}/{rowId}/discardChanges

When called, given document/included document is discarded, which means:

  • if it's a new document (not yet saved) it will be completely discarded
  • if it's an existing document with changes not yet saved, those changes will be discarded

References
teosarca added a commit that referenced this issue Oct 30, 2017
@teosarca
Implement document discardChanges endpoint
a56c027 
#652
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Nov 5, 2017
@metas-ts
Update ReleaseNotes.md
76900a8 
[#652](metasfresh/metasfresh-webui-api-legacy#652) Implement document discardChanges endpoint
[#1294](metasfresh/metasfresh-webui-frontend-legacy#1294) window actions shall respect the "disabled" flag
[#650](metasfresh/metasfresh-webui-api-legacy#650) flatrate contractstatus not refresh in single view after terminated
[#2859](#2859) Pre-enddate termination of flatrate created compensation sales order
[#2854](#2854) Save Termination Reason when terminating subscription
[#2676](#2676) flatrate: make subscription progress reflecting progress

me-45
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Nov 5, 2017
@metas-ts
Update ReleaseNotes.md
3263fda 
[#652](metasfresh/metasfresh-webui-api-legacy#652) Implement document discardChanges endpoint
[#1294](metasfresh/metasfresh-webui-frontend-legacy#1294) window actions shall respect the "disabled" flag
[#650](metasfresh/metasfresh-webui-api-legacy#650) flatrate contractstatus not refresh in single view after terminated
[#2859](#2859) Pre-enddate termination of flatrate created compensation sales order
[#2854](#2854) Save Termination Reason when terminating subscription
[#2676](#2676) flatrate: make subscription progress reflecting progress

me-45

(cherry picked from commit 76900a8)
@metas-lc metas-lc self-assigned this Dec 20, 2017
@metas-lc
Copy link

IT
tested with bpartner and sales order:
added rows without country / product => the rows from the tabs were discarded OK
created new bpartner and sales order and moved to other window without saving => the documents were discarded OK

updated bpartner and sales order by removing mandatory fields from header, then moved to other windows => my changes were discarded OK
updated line in sales order by removing the product, moved to another window => my changes were discarded OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metas-lc metas-lc

Labels
branch:master branch:release type:enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@teosarca @metas-ts @metas-lc