Input event sequence #187
Merged
Input event sequence #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilder Use overloads of one function instead of a different function name for each event.
Use MPark.Variant to make it work with older compilers.
…nd metadata of the events. This required the introduction of a few new events to avoid having events creating multiple edges/nodes.
sabel83
force-pushed
the
input_event_sequence
branch
2 times, most recently
from
86f85db
to
67b69c3
Compare
r0mai
reviewed
Apr 4, 2018
docs/about/changelog.md
Outdated
| * When a template is instantiated in the environment (eg. by files included | ||
| into the shell) and then an instantiation attempt of the same template | ||
| with the same arguments is debugged with mdb, only the memoization is | ||
| shown and the original instantiation is not displayed in the debugger. |
There was a problem hiding this comment.
This might be a usability regression. I think it's common to include a whole cpp into a metashell session which already instantiates the problematic template, which is then later debugged. Can we provide some kind of workaround proposal for the user if this is the case?
One workaround could be to debug the whole environment, and inserting a breakpoint for the template in question. This approach could become difficult if the original name of the type is hidden under multiple layers of typedefs and such and specifying the breakpoint regex is impossible.
There was a problem hiding this comment.
I have restored the old behaviour by adding filter_replay_instantiations.
sabel83
force-pushed
the
input_event_sequence
branch
4 times, most recently
from
aad566a
to
d27918a
Compare
sabel83
force-pushed
the
input_event_sequence
branch
2 times, most recently
from
688c315
to
0268318
Compare
…e graph built from it
Also apart from template instantiation and memoization events, all template events are made unique nodes of the metaprogram graph to avoid moving events to the wrong parents (or removing them from the graph) because of different events getting merged due to having the same name, point of instantiation and source location.
sabel83
force-pushed
the
input_event_sequence
branch
from
8129865
to
47812b8
Compare
r0mai
approved these changes
Apr 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.