Should Asset Helpers Work With Digests?

[metaskills]

Spawed from ticket #3 which mentioned that given this.

.myimage() {
  background-image: image-url("less_framework/less.png");
}
#container {
  .myimage();
}

Compiles with rake assets:precompile to this content #container{background-image:url(/assets/less_framework/less.png);}. The question is should there be a digest in that asset url? Here is what is output to the assets directory.

• less_framework/less-ef9b99c1df7d13853cb626bdf3f1f269.png
• less_framework/less.png

Will need to look at sass-rails and see if it does this too. Feedback appreciated.

[cowboyd]

I'm not sure I'm grasping the problem:

we have in shared less lib (brought in via @import) the following definition to add background noise to an element:

.noisy() {
  background-image: image-url("bg-noise.jpg");
}

this noisy class is on the body tag:

body {
  color: #849bA0;
  background-color: @background-gray;
  .noisy;
}

which results in the following line in the rendered file application-26c81a0f126d46f5968064dc0f38123a.css

body {
  color: #849bA0;
  background-color: #3d4646;
  background-image: url(/assets/bg-noise-c7bdb4476407313f26fbcc702e77dee8.jpg);
}

Is this not what you're seeing in your environment?

[metaskills]

Wow, no I am not! I was just about to post this on my same test projects sass too which means it has to be something on my end. Odd.

Sass does the same thing as we do. Is this a configuration failure on my end or does anything that implements asset helpers for sprocket care about this? Perhaps a rails or sprockets issue? My tests below.

I hav an image in vendor/assets/images/sass_framework/sass.png. I then have this file in vendor/assets/stylesheets/sass_framework/base.css.scss

@mixin myimage() {
  background-image: image-url("sass_framework/sass.png");
}

I then have my application.css setup like so.

/*
 *= require site/sass
 *= require_self
*/

And my app/assets/site/sass.css.scss setup like so.

@import 'sass_framework/base';

#container {
  @include myimage;
}

This outputs the following in application.css.

#container{background-image:url(/assets/sass_framework/sass.png);}

[metaskills]

OH, I GET IT! The digests are included in the generated CSS that also has a digest. Brilliant! Closing this ticket.

[stouset]

So... you're not going to fix this?

[metaskills]

There is nothing to fix.

[metaskills]

We are working just like sass/rails wants us too. Seems they only put the digest urls in the digest content. As @cowboyd pointed out and it took me awhile to notice/learn.

[stouset]

Oh, yep. I see it too. Tricky.