Some modernisations, some corrections/hardening, some pedantry #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eval is used for dynamic array and hashtable assignments, all of which are single commands, so can and should be safely double-quoted.
Not sure if this was an ancient bug or strange behaviour, or just a misunderstanding of shell quoting (probably the latter!), but there's nom need to use `-f -` anymore.
No splitting, globbing, etc. could occur with these, but whatever!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the parts of #7 which I was uncertain about reviewing at the time in terms of purpose, rather than shellcheck test number. Today I learned that given:
both
and
are in fact equivalent, but given that neither GitHub's nor my editor's syntax highlighting understands that the variable in the first one really is a variable, I went with the second syntax, just for the highlight that
$iis not literal.With this PR, both scripts pass shellcheck 0.9.0.