Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canceling HDFS type snapshot is failed #528

Closed
ecoloy opened this issue Oct 23, 2018 · 5 comments
Closed

Canceling HDFS type snapshot is failed #528

ecoloy opened this issue Oct 23, 2018 · 5 comments
Assignees
Labels
bug Something isn't working @dataprep Component Name : Data preparation
Milestone

Comments

@ecoloy
Copy link

ecoloy commented Oct 23, 2018

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Data Preparation > Dataset
  2. Create dataset using CSV file below
    police-department-calls-for-service.csv.zip
  3. Create dataflow using the dataset above
  4. Click Wrangled dataset in the dataflow detail page
  5. Create snapshot with HDFS location setting
  6. Click 'Go to snapshot list' button in progress popup
  7. Click snapshot item which preparing on lists
  8. Click 'cancel' button at right side on progress bar
  9. Click 'Yes' button on confirm popup
  10. See warning toast

Expected behavior
The snapshot should be successfully canceled

Screenshots
2018-10-23 2 21 49

Desktop (please complete the following information):

  • OS: MacOS
  • Browser: Chrome
  • Version: 70.3

Additional context
Add any other context about the problem here.

@joohokim1 joohokim1 added bug Something isn't working @dataprep Component Name : Data preparation labels Oct 23, 2018
@joohokim1 joohokim1 added this to the 3.1.0 milestone Oct 23, 2018
@mh0203 mh0203 self-assigned this Oct 30, 2018
@mh0203
Copy link
Contributor

mh0203 commented Oct 30, 2018

테스트 해본 결과 이미 cancel 가능한 시점을 지났기 때문에 취소가 불가능한 상황인 것 같습니다.
현재 "THIS_SNAPSHOT_IS_ALREADY_CREATED_OR_FAILED"로 리턴되는 메시지에 대해서 에러 토스트 대신 다른 피드백을 주는 것이좋을 것 같습니다.

It seems to that snapshot canceling is impossible because snapshot generating process is already passed cancel point.
It would be good to give different feedback to users when "THIS_SNAPSHOT_IS_ALREADY_CREATED_OR_FALED" msg is returned.

@joohokim1
Copy link
Contributor

이 건은 생각할 일이 많네요. 기획단계부터 확실히 하고 작업을 재개하는 것이 좋겠습니다.

We need more consideration about this issue. It is better to start over from the UI/UX design stage.

@joohokim1
Copy link
Contributor

본 이슈는 기획부터 다시 하고 3.0.7로 옮기겠습니다.

I am going to revise this issue in 3.0.7. Planning should come first

@joohokim1
Copy link
Contributor

Finished redesigning.

If the user requests cancellation, we will delete all of the following, regardless of the snapshot creation status.

  1. Directory with Output
  2. Hive table (if any)
  3. PrepSnapshot entity

As more explanation for each status,

  • SUCCESS: Even if it is completely created, remove all three of the above without any question.
  • FAILURE: Do best to remove all three of the above.
  • RUNNING: First, set to CANCELED, then all three of above should be cleared in the whole processing engine. The snapshot shouldn't be shown on the snapshot list. The garbage problem is not considered at this time.

Let's proceed as above.

기획을 마쳤습니다.

사용자가 취소를 요청한 경우, snapshot 생성 상태에 관계없이 다음 내용을 모두 지우는 것으로 하겠습니다.

1. Output이 쌓인 directory
2. Hive table (if any)
3. PrepSnapshot entity

각 status에 대해 부가적으로 설명을 하자면,

  • SUCCESS: 완벽하게 다 만들어졌더라도, 묻지도 따지지도 않고, 위의 3가지를 모두 지움
  • FAILURE: 최선을 다해 위의 3가지를 모두 지움
  • RUNNING: 일단 CANCELED로 해놓고, 전수처리 프로세스에서 위의 3가지를 모두 지움. Snapshot list 등에서는 이 snapshot이 없는 것으로 취급. Garbage가 남는 케이스는 현재로서는 고려하지 않기로 함.

위처럼 진행을 합시다.

@joohokim1 joohokim1 modified the milestones: 3.1.0, 3.2.0 Nov 21, 2018
@mh0203
Copy link
Contributor

mh0203 commented Dec 18, 2018

This issue was fixed by below PR.
#784

@mh0203 mh0203 closed this as completed Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working @dataprep Component Name : Data preparation
Projects
None yet
Development

No branches or pull requests

3 participants