Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): change rest queries interface #444

Merged
merged 9 commits into from Oct 10, 2023

Conversation

afmika
Copy link
Contributor

@afmika afmika commented Oct 9, 2023

No description provided.

@afmika afmika requested review from zifeo and Natoandro October 9, 2023 15:22
zifeo
zifeo previously approved these changes Oct 9, 2023
Copy link
Member

@zifeo zifeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zifeo
Copy link
Member

zifeo commented Oct 9, 2023

@afmika can you add a short page in the documentation? under guide?

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Attention: 90 lines in your changes are missing coverage. Please review.

Comparison is base (cdbae44) 80.75% compared to head (a50b0cc) 80.72%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #444      +/-   ##
==========================================
- Coverage   80.75%   80.72%   -0.04%     
==========================================
  Files          92       91       -1     
  Lines       10277    10327      +50     
  Branches     1176     1181       +5     
==========================================
+ Hits         8299     8336      +37     
- Misses       1959     1972      +13     
  Partials       19       19              
Files Coverage Δ
typegate/src/engine/computation_engine.ts 87.05% <ø> (ø)
typegate/src/engine/planner/dependency_resolver.ts 94.16% <100.00%> (ø)
typegate/src/engine/planner/injection_utils.ts 84.61% <ø> (ø)
typegate/src/engine/planner/mod.ts 89.70% <100.00%> (ø)
typegate/src/engine/planner/policies.ts 93.41% <100.00%> (ø)
typegate/src/engine/query_engine.ts 85.95% <100.00%> (ø)
typegate/src/engine/stage_id.ts 73.17% <ø> (ø)
typegate/src/engine/typecheck/code_generator.ts 94.53% <100.00%> (ø)
typegate/src/engine/typecheck/common.ts 91.66% <ø> (ø)
typegate/src/engine/typecheck/input.ts 97.97% <ø> (ø)
... and 54 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zifeo zifeo merged commit bf5df69 into main Oct 10, 2023
12 checks passed
@zifeo zifeo deleted the MET-236-graph-change-rest-queries-interface branch October 10, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants