Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): missing ts modules from typegate image #577

Merged
merged 5 commits into from Feb 5, 2024

Conversation

Yohe-Am
Copy link
Contributor

@Yohe-Am Yohe-Am commented Feb 3, 2024

Adds a check step to the typegate's Dockerfile and converts the .dockerignore to be a whitelist.

Motivation and context

The image for 0.3.3 has some files missing.

Migration notes

No changes required

Checklist

  • The change come with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

@Yohe-Am Yohe-Am requested a review from zifeo February 3, 2024 00:37
Copy link

codecov bot commented Feb 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (586e70c) 73.75% compared to head (724b8cd) 73.75%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #577   +/-   ##
=======================================
  Coverage   73.75%   73.75%           
=======================================
  Files         100      100           
  Lines       11610    11610           
  Branches     1238     1238           
=======================================
  Hits         8563     8563           
  Misses       3027     3027           
  Partials       20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dev/Dockerfile Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
typegate/src/runtimes/deno/worker.ts Show resolved Hide resolved
@Yohe-Am Yohe-Am requested a review from zifeo February 5, 2024 12:50
@Yohe-Am Yohe-Am merged commit 392435a into main Feb 5, 2024
11 checks passed
@Yohe-Am Yohe-Am deleted the fix/missing-files-from-oci branch February 5, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants