Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hotfix typo in release.yml #580

Merged
merged 1 commit into from Feb 5, 2024
Merged

fix: hotfix typo in release.yml #580

merged 1 commit into from Feb 5, 2024

Conversation

Yohe-Am
Copy link
Contributor

@Yohe-Am Yohe-Am commented Feb 5, 2024

Yes, another one lol. This removes the target param from the release builder which will default to the last stage of the Dockerfile, the epoint stage. I elected to remove the parameter rather than replacing the value in order to remove one more place future changes will have to consider. (convention better than configuration the saying goes (i think)).

Motivation and context

The typegate images currently have the wrong target and thus the wrong entrypoint command.

Migration notes

No changes required

Checklist

  • The change come with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

@Yohe-Am Yohe-Am requested a review from zifeo February 5, 2024 21:03
@zifeo zifeo merged commit efabeae into main Feb 5, 2024
9 checks passed
@zifeo zifeo deleted the fix/yet-another-ci-typo branch February 5, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants