Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typegate): fix tmp dir issue, bump to 0.3.4 #583

Merged
merged 9 commits into from
Feb 10, 2024

Conversation

Yohe-Am
Copy link
Contributor

@Yohe-Am Yohe-Am commented Feb 7, 2024

  • Fixes an issue with the prisma migration code being unable to properly mktmpd when running in the typegate images.
  • Removes cross usage for all but the aarch64-unknown-linux-gnu target in the meta-cli release jobs. Deno doesn't like being cross compiled, doesn't like being built by the cross toolchain in general (even for the native target). The consequence of all this is that the aarch64-unknown-linux-gnu target will temporarily lack the full version builds.
  • This also bumps the version of the 0.3.4 to get the fix out.

Motivation and context

The main TMP_DIR was not created properly in the typegate Dockerfile.

Migration notes

No changes required

Checklist

  • The change come with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

@Yohe-Am Yohe-Am requested a review from zifeo February 7, 2024 23:41
@Yohe-Am Yohe-Am linked an issue Feb 7, 2024 that may be closed by this pull request
zifeo
zifeo previously approved these changes Feb 8, 2024
afmika
afmika previously approved these changes Feb 8, 2024
Copy link
Contributor

@afmika afmika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, btw the failing website tests are already resolved in #579

@Yohe-Am Yohe-Am dismissed stale reviews from afmika and zifeo via 5331cb8 February 8, 2024 23:06
@Yohe-Am
Copy link
Contributor Author

Yohe-Am commented Feb 8, 2024

@afmika thanks. I got foiled earlier due to an error on my part. (forgot to run whiz -r setup after pulling main which broke typegraphs due to the new dep packages added for @typegraph/sdk).

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (586e70c) 73.75% compared to head (102b5da) 73.75%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #583   +/-   ##
=======================================
  Coverage   73.75%   73.75%           
=======================================
  Files         100      100           
  Lines       11610    11610           
  Branches     1238     1238           
=======================================
  Hits         8563     8563           
  Misses       3027     3027           
  Partials       20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yohe-Am Yohe-Am requested a review from zifeo February 9, 2024 00:27
@Yohe-Am Yohe-Am marked this pull request as draft February 9, 2024 04:01
zifeo
zifeo previously approved these changes Feb 9, 2024
afmika
afmika previously approved these changes Feb 9, 2024
@Yohe-Am Yohe-Am dismissed stale reviews from afmika and zifeo via 46d889c February 9, 2024 21:35
@Yohe-Am Yohe-Am marked this pull request as ready for review February 10, 2024 01:06
@Yohe-Am Yohe-Am merged commit 394440a into main Feb 10, 2024
23 checks passed
@Yohe-Am Yohe-Am deleted the fix/tmp-dir-issue-image branch February 10, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"tmp dir does not exist"
3 participants