-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(typegate): fix tmp
dir issue, bump to 0.3.4
#583
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, btw the failing website
tests are already resolved in #579
@afmika thanks. I got foiled earlier due to an error on my part. (forgot to run |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #583 +/- ##
=======================================
Coverage 73.75% 73.75%
=======================================
Files 100 100
Lines 11610 11610
Branches 1238 1238
=======================================
Hits 8563 8563
Misses 3027 3027
Partials 20 20 ☔ View full report in Codecov by Sentry. |
mktmpd
when running in thetypegate
images.cross
usage for all but theaarch64-unknown-linux-gnu
target in themeta-cli
release jobs. Deno doesn't like being cross compiled, doesn't like being built by the cross toolchain in general (even for the native target). The consequence of all this is that theaarch64-unknown-linux-gnu
target will temporarily lack thefull
version builds.Motivation and context
The main
TMP_DIR
was not created properly in thetypegate
Dockerfile
.Migration notes
No changes required
Checklist