Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: esm customizer for typegate deno ext #606

Merged
merged 8 commits into from Mar 4, 2024
Merged

Conversation

Yohe-Am
Copy link
Contributor

@Yohe-Am Yohe-Am commented Mar 1, 2024

Enables v8 snapshots integration for meta typegate subcommand and the standalone typegate. Also bumps deno to 1.41.0.

Motivation and context

Fixes #591

Migration notes

No changes required

Checklist

  • The change come with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

Copy link

linear bot commented Mar 1, 2024

Natoandro
Natoandro previously approved these changes Mar 1, 2024
typegate/engine/src/snapshot.rs Outdated Show resolved Hide resolved
typegate/engine/Cargo.toml Outdated Show resolved Hide resolved
typegate/engine/Cargo.toml Outdated Show resolved Hide resolved
dev/Dockerfile Outdated Show resolved Hide resolved
@Yohe-Am Yohe-Am changed the title fix: use deno snapshotting fix: ~~use deno snapshotting~~ manual override for typegate deno ext Mar 3, 2024
@Yohe-Am Yohe-Am changed the title fix: ~~use deno snapshotting~~ manual override for typegate deno ext fix: esm customizer for typegate deno ext Mar 3, 2024
@Yohe-Am Yohe-Am requested a review from zifeo March 3, 2024 02:18
Copy link

codecov bot commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.14%. Comparing base (977a0e1) to head (21f6418).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #606   +/-   ##
=======================================
  Coverage   74.14%   74.14%           
=======================================
  Files         111      111           
  Lines       12425    12425           
  Branches     1313     1313           
=======================================
  Hits         9213     9213           
  Misses       3192     3192           
  Partials       20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yohe-Am
Copy link
Contributor Author

Yohe-Am commented Mar 3, 2024

Note: I also run into the same issues I'd faced with the snapshot based xtask in the customizer approach. (it wasn't related to snapshotting as it turns out. The snapshot setup did obscure it) but I did manage to fix it. I.e., I could probably go back to the snapshot paths at this point. I've decided against it though on the basis of compilation times.

The 2000 packages quote from last time turned out to be due to duplicate builds necessitated by build scripts (or some misuse on my part but I can't figure out where). 2000 packages not only takes way more time but adds way too much bloated artifacts which are even more painful at this point. It also seems to have made the cargo change detection more brittle, unnecessarily re-building packages leading to more artifacts.

We'll probably want to enable snapshots at some point but I think it might be better to keep it simple until our dependency tree has stabilized.

@Yohe-Am Yohe-Am merged commit 5e226c4 into main Mar 4, 2024
10 checks passed
@Yohe-Am Yohe-Am deleted the fix/MET-400/meta-typegate branch March 4, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

meta typegate doesn't work
3 participants