Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply from context #616

Merged
merged 3 commits into from Mar 7, 2024
Merged

fix: apply from context #616

merged 3 commits into from Mar 7, 2024

Conversation

Natoandro
Copy link
Contributor

Fix type validators for apply from context.

Motivation and context

Bug.

Migration notes

N/A

Checklist

  • The change come with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 74.11%. Comparing base (1cb26cf) to head (c4f167e).

Files Patch % Lines
...pegate/src/engine/planner/parameter_transformer.ts 70.73% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #616      +/-   ##
==========================================
- Coverage   74.14%   74.11%   -0.04%     
==========================================
  Files         111      110       -1     
  Lines       12425    12424       -1     
  Branches     1313     1308       -5     
==========================================
- Hits         9213     9208       -5     
- Misses       3192     3196       +4     
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

afmika
afmika previously approved these changes Mar 7, 2024
@Natoandro Natoandro merged commit 04c7565 into main Mar 7, 2024
10 checks passed
@Natoandro Natoandro deleted the fix/union-context branch March 7, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants