-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(SDK): Artifact upload fails when same file referred multiple times #715
Conversation
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: Teo Stocco <zifeo@users.noreply.github.com>
… resolution during runtime
…est/artifact-tests
WalkthroughThe recent changes introduce and enhance functionalities for testing Deno and Python runtimes within the TypeGraph framework. This involves adding new scripts for handling artifact deployments, defining policies, and setting up runtime environments. Additionally, several test cases have been implemented to ensure the proper functioning of these features, including scenarios for no artifacts, duplicate artifacts, and runtime synchronization. Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (12)
Additional comments not posted (24)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 5
Out of diff range and nitpick comments (4)
typegate/tests/runtimes/python/python_sync_test.ts (4)
4-13
: Ensure all imported modules are necessary and used in the code.Consider removing any unused imports to keep the code clean and maintainable.
16-18
: Consider adding comments to explain the purpose of these constants.Adding comments can improve code readability and maintainability.
31-48
: ThesyncConfig
object is well-defined, but consider adding comments to explain each section.Adding comments can help future developers understand the configuration more easily.
530-594
: Consider removing the commented-out test cases if they are no longer needed.Keeping commented-out code can clutter the codebase. If these tests are not required, it's better to remove them.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #715 +/- ##
==========================================
+ Coverage 73.85% 74.05% +0.19%
==========================================
Files 120 120
Lines 13777 13777
Branches 1393 1408 +15
==========================================
+ Hits 10175 10202 +27
+ Misses 3576 3549 -27
Partials 26 26 ☔ View full report in Codecov by Sentry. |
Issue: MET-501
Migration notes
No Migrations Needed
...
Summary by CodeRabbit
New Features
Bug Fixes
Tests
Documentation