Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ChanneldWorldSettings #80

Closed
indiest opened this issue Sep 11, 2023 · 0 comments · Fixed by #98
Closed

Implement ChanneldWorldSettings #80

indiest opened this issue Sep 11, 2023 · 0 comments · Fixed by #98
Assignees
Milestone

Comments

@indiest
Copy link
Collaborator

indiest commented Sep 11, 2023

What

A place to store the settings of the view class, server groups, and channeld launch args individually for each map.

Why

In a project with multiple maps that have different channel settings (e.g. the demos project), opening and testing different maps in the editor can be troublesome - if a developer forgets to set the view class, the server groups, or the channeld launch args properly every time opening a map, s/he may fail to run the map.

How

Save the settings per map. WorldSettings is instantiated per map, and can be extended easily.

Things to discover:

  • Is it able to get the WorldSettings instance from the editor code?
  • Add #if WITH_EDITORONLY_DATA for the server groups and channeld launch args and see if they are saved and loaded properly
@indiest indiest added this to the v0.8 milestone Apr 24, 2024
@indiest indiest self-assigned this May 22, 2024
@indiest indiest linked a pull request Sep 11, 2024 that will close this issue
@indiest indiest closed this as completed Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant