Skip to content
This repository has been archived by the owner on Mar 21, 2021. It is now read-only.

Replace color codes with color scheme #16

Open
metbril opened this issue Mar 2, 2018 · 4 comments
Open

Replace color codes with color scheme #16

metbril opened this issue Mar 2, 2018 · 4 comments

Comments

@metbril
Copy link
Owner

metbril commented Mar 2, 2018

The color scheme could be included with the icons yaml file, but this would be less flexible (to generate a personal flavor.

Other option is to have a separate config file per color scheme (.conf of .yaml) that is parsed during execution.

A third option is to set the colors through the command line. This is a lot of hassle, so the least favorable.

For now, I am thinking of option 2, a separate .conf (simple ini file type or json) configuration file type, that can be parsed as a command line parameter and defaults to mdi.conf.

@metbril
Copy link
Owner Author

metbril commented Mar 2, 2018

Related to #5

@mueller-ma
Copy link
Contributor

Can you look at the script in my repo? I have a list for random colors. You could add more lists and decide which to use via cli parameter.

@metbril
Copy link
Owner Author

metbril commented Mar 4, 2018

I like your implementation; it's simple and extensible. And it serves my personal purposes, too.

In your version of the script, however, the color codes are hard coded. Initially my intention was to have the script as generic as possible and have the user feed it any variable information through configuration. With sensible defaults. This would imply that no color code should be in the script itself.

If the future of this repo is to be moved in the openHAB organization, and this is the way forward for creating a modern icon set for OH, then I would't mind accepting a PR.

@mueller-ma
Copy link
Contributor

I'm waiting for a comment by kai in the openhab2 addons issue and based on that, start contributing back to you repo or move the script in any other repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants