Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new parameter for fitting occasion with no release #26

Closed
wants to merge 1 commit into from

Conversation

yi-Xu-0100
Copy link

Add new parameter firstRelease for fitting occasion with no release.

I try to fix #20.

@yi-Xu-0100
Copy link
Author

Finally, I successfully learned how to set a signature for my commit.

@yi-Xu-0100
Copy link
Author

After completing my first simple project, I realized that the commit before the first release had many tests and confusing fixes.

Perhaps the commit from the beginning of the project to the completion of all basic functions is not suitable as the publishing of the first release. I should use the function introduction to complete the introduction of the first stable version.

I will close this request and complete my personal project in a better way.

@yi-Xu-0100 yi-Xu-0100 closed this Oct 2, 2020
@metcalfc
Copy link
Owner

metcalfc commented Oct 2, 2020

Thanks for taking a look at it. Initial project work is tough. Your approach is similar to what I've done. Once my project was in a ready state, I cut an "initial release" to show that it was in a place to start. Then I was able to changenote all that came after.

Awesome work finding out that it didn't work though. Seriously its super helpful in OSS to know what doesn't work and what shouldn't be added. I appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[error]Not Found
2 participants