Make Apollo npm independent #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Apollo is often installed independently anyway this saves us space in the bundle. Also updated syntax to Meteor 2.8
|
@Grubba27 here is my proposal to remove |
|
I would approve it, but before that, I would like some kind of heads up in the community, maybe a community post to get people opinions on it |
|
@Grubba27 on it. Writing a dev.to article on it. Also the major version push will not allow update unless done manually. |
|
Oh got it. Yeah, the foruns would be a nice place to discuss this |
|
@Grubba27 I think that at his point we can merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
@apollo/clientnpm package from the package and have it be installed by users themselves. This takes care of duplication when you have the npm package installed in your app which then duplicates it in the app bundle. Removing it and having it up to the app to add Apollo client reduces the bundle and we don't have to worry about constantly updating it to stay up with the latest Apollo version.