Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split packages each into its own repository #12

Closed
mitar opened this issue Mar 6, 2016 · 16 comments
Closed

Split packages each into its own repository #12

mitar opened this issue Mar 6, 2016 · 16 comments

Comments

@mitar
Copy link
Collaborator

mitar commented Mar 6, 2016

This repository still contains multiple packages. Would it be better to really split each one into a separate repository?

Especially with NPM, to my knowledge, this would allow one to easily depend with a package on the forked git repository.

@stubailo
Copy link
Contributor

stubailo commented Mar 6, 2016

Hmm there are definitely pros and cons. There are also disadvantages to having a ton of separate repositories. In fact the limitation of NPM in installing packages from git is about the only advantage I can think of - are there others?

@mitar
Copy link
Collaborator Author

mitar commented Mar 6, 2016

You cannot include it as a git submodule. If I try to include this repository into packages inside my Meteor app, it will not work.

@mitar
Copy link
Collaborator Author

mitar commented Mar 6, 2016

I think multiple repositories can be solved easily by using some common prefix, or a new GitHub organization.

@mitar
Copy link
Collaborator Author

mitar commented Mar 6, 2016

https://github.com/meteor-package/blaze sounds pretty cool.

@stubailo
Copy link
Contributor

stubailo commented Mar 6, 2016

Yeah the organization approach would make the most sense if it were split up.

@martijnwalraven
Copy link
Contributor

I think the biggest downside of one package per repository is that you may want to keep GitHub issues and pull requests for closely related packages together.

@stubailo
Copy link
Contributor

I think once Zube.io creates a multi-repository view, it could be less of an issue - we could just use that to manage issues across repos.

@mitar
Copy link
Collaborator Author

mitar commented Mar 10, 2016

Also, we could have a main repository for issues, and all other repositories could have issues closed. So all issues are in the same place, and is like a landing project (maybe without even having the code by itself). Which then links to all other repositories and so on.

@mitar
Copy link
Collaborator Author

mitar commented Mar 10, 2016

(If we are talking about meteor-package organization.)

@mitar
Copy link
Collaborator Author

mitar commented Mar 10, 2016

Related: npm/npm#2974

@martijnwalraven
Copy link
Contributor

This also seems relevant, if we are prepared to engage in improving NPM:

To be clear, monorepo support is not something that's on the CLI team's roadmap for the next 6-12 months. I'm interested in seeing better support for it within the CLI, but the team isn't going to have the time and attention to do it ourselves. For that reason, specific proposals (perhaps in the form of (prototype) code) are going to be more useful than generic requests for improved monorepo support.

@mitar
Copy link
Collaborator Author

mitar commented Mar 10, 2016

Should we try to contribute to NPM this feature then?

@mitar mitar added this to the Next steps milestone Apr 17, 2016
@laosb
Copy link

laosb commented Apr 30, 2016

I've prepared an organization for meteor packages -- ourmeteor. I've also taken the ourmeteor.com for further use. If you have any suggestions on OurMeteor, let it happen on ourmeteor/discussions.
Here're my cents of OurMeteor.

@mitar
Copy link
Collaborator Author

mitar commented Aug 29, 2016

I am moving this issue to a later milestone. For now we are going with Meteor-only packages.

@mitar mitar modified the milestones: Later steps, Next steps Aug 29, 2016
@stubailo
Copy link
Contributor

If we want to go with an NPM monorepo, the Babel folks have this cool project that they use to manage a ton of packages. Might be worth looking at later: https://lernajs.io/

@mitar mitar removed this from the Next minor version milestone Sep 30, 2016
@mitar
Copy link
Collaborator Author

mitar commented Jan 6, 2017

Let's close this for now and keep it monorepo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Blaze development
Planned – general
Development

No branches or pull requests

4 participants