This repository has been archived by the owner on Oct 2, 2021. It is now read-only.
Don't blacklist an app version because the app started in background #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnwalraven
added a commit
that referenced
this pull request
Oct 3, 2016
|
Thanks for the pull request, sorry it took me so long to merge. I've updated it for Swift 3 and I made a small change to the logic. Instead of never creating the timer, it is now not started when the app is in the background. But if the app is in the foreground when reloading the page at a later time, it will start as usual. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On iOS the web app local server is careful to avoid blacklisting the app version just because the app transitioned into the background and Meteor startup didn't complete for that reason.
However, it's also possible for an app in iOS to start in the background when it receives a notification.
(See for example URLSessionDidFinishEventsForBackgroundURLSession).
This isn't caught by the "app did enter background" event because that's only called when the app transitions to the background.
This change adds a check so that the startup timer is only started if the app is in the foreground, avoiding blacklisting the app version because the app started in the background.