Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

less plugin compileOneFileLater crashes meteor-tool on compile error #10434

Open
sebakerckhof opened this issue Jan 28, 2019 · 4 comments
Open
Labels
confirmed We want to fix or implement it

Comments

@sebakerckhof
Copy link
Contributor

If the less compiler encounters an error (

) it will not have a result in compileOneFileLater here:
const result = await getResult();

which currently crashes meteor tool.

reproduction: https://github.com/sebakerckhof/meteorless

@stale
Copy link

stale bot commented Dec 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale-bot label Dec 10, 2019
@sebakerckhof
Copy link
Contributor Author

still relevant

@stale stale bot removed the stale-bot label Dec 11, 2019
@filipenevola filipenevola added the confirmed We want to fix or implement it label Dec 11, 2019
@stale
Copy link

stale bot commented Oct 31, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@StorytellerCZ
Copy link
Collaborator

Isn't crashing the meteor tool with an error the proper way to handle this? What should be the behavior here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed We want to fix or implement it
Projects
None yet
Development

No branches or pull requests

3 participants