Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regeneratorRuntime not loaded on Android User-Agent with coffeescript #10606

Open
edemaine opened this issue Jul 3, 2019 · 16 comments
Open

regeneratorRuntime not loaded on Android User-Agent with coffeescript #10606

edemaine opened this issue Jul 3, 2019 · 16 comments
Assignees
Labels
confirmed We want to fix or implement it Project:Isobuild

Comments

@edemaine
Copy link
Contributor

edemaine commented Jul 3, 2019

Consider the following simple example for client/main.coffee (demo repo):

words = ->
  yield 'hello'
  yield 'world'

for word from words()
  console.log word

In a Chrome browser (on Windows), this correctly logs "hello" and "world" to console. However, if I set my User-Agent to Mozilla/5.0 (Linux; Android 4.1.1; Nexus 7 Build/JRO03D) AppleWebKit/535.19 (KHTML, like Gecko) Chrome/18.0.1025.166 Safari/535.19 (the Android option in User-Agent Switcher for Chrome), I get the following error message:

main.coffee:1 Uncaught ReferenceError: regeneratorRuntime is not defined
    at main.coffee (main.coffee:1)
    at fileEvaluate (modules-runtime.js?hash=d3c3e5d67c95f97a60888bda7373292efad3be5e:346)
    at Module.require (modules-runtime.js?hash=d3c3e5d67c95f97a60888bda7373292efad3be5e:248)
    at require (modules-runtime.js?hash=d3c3e5d67c95f97a60888bda7373292efad3be5e:268)
    at app.js?hash=a04d86c6ea798e9fbb7d554b6c22aa47dbdae283:67

It seems that in this combination, somehow Babel is getting engaged (old browser), yet its polyfill isn't included. (This is a minimal example of an error that occurred in a real app using an actual Android device -- but this reproduction seems to accurately depict the problem.)

On the other hand, if I do equivalent code in ECMAScript, everything works fine no matter the User-Agent (to test in the demo repo, just change meteor.mainModule.client from client/main.coffee to client/main.js):

function* words() {
  yield 'hello';
  yield 'world';
}

for (word of words()) {
  console.log(word);
}

I conclude that this is probably a bug in the coffeescript module.

@stale
Copy link

stale bot commented Dec 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale-bot label Dec 10, 2019
@stale
Copy link

stale bot commented Dec 18, 2019

This issue has been automatically closed it has not had recent activity.

@stale stale bot closed this as completed Dec 18, 2019
@edemaine
Copy link
Contributor Author

I just checked that this bug is not fixed in Meteor 1.8.2. (Demo repo has been updated accordingly.) Could you reopen the issue?

@benjamn benjamn reopened this Dec 18, 2019
@stale stale bot removed the stale-bot label Dec 18, 2019
@benjamn benjamn modified the milestones: Release 1.8.2, Release 1.8.4 Dec 18, 2019
@stale
Copy link

stale bot commented Jan 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale-bot label Jan 19, 2020
@edemaine
Copy link
Contributor Author

I assume, but have not checked, that this still hasn't been fixed, so should not be closed.

@stale stale bot removed the stale-bot label Jan 19, 2020
@stale
Copy link

stale bot commented Feb 21, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale-bot label Feb 21, 2020
@edemaine
Copy link
Contributor Author

I can confirm it's still a bug in the latest Meteor 1.9. My poor Android users. 🙁

@stale stale bot removed the stale-bot label Feb 21, 2020
@stale
Copy link

stale bot commented Apr 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale-bot label Apr 3, 2020
@edemaine
Copy link
Contributor Author

edemaine commented Apr 4, 2020

I'm not aware of this being fixed yet. Would appreciate some attention, or some pointers on what I might investigate...

@stale stale bot removed the stale-bot label Apr 4, 2020
@edemaine
Copy link
Contributor Author

edemaine commented Apr 7, 2020

The same issue arises on the SeaMonkey browser.

@stale
Copy link

stale bot commented May 9, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale-bot label May 9, 2020
@edemaine
Copy link
Contributor Author

edemaine commented May 9, 2020

Still an issue. 🙁

@stale stale bot removed the stale-bot label May 9, 2020
@stale
Copy link

stale bot commented Oct 31, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale-bot label Oct 31, 2020
@edemaine
Copy link
Contributor Author

edemaine commented Nov 1, 2020

This is still an important issue for me. @GeoffreyBooth as the maintainer of the coffeescript module, perhaps you could take a look?

@stale stale bot removed the stale-bot label Nov 1, 2020
@GeoffreyBooth
Copy link
Contributor

This is still an important issue for me. @GeoffreyBooth as the maintainer of the coffeescript module, perhaps you could take a look?

I’m sorry, I don’t have time at the moment. I would think it’s something to do with the Babel compiler build plugin.

@filipenevola filipenevola added confirmed We want to fix or implement it and removed pinned labels Nov 11, 2020
@filipenevola filipenevola removed this from the Release vNext milestone Feb 25, 2021
@StorytellerCZ StorytellerCZ added this to the Release 2.5 milestone Aug 12, 2021
@StorytellerCZ
Copy link
Collaborator

I'll look into updating coffeescript for Meteor 2.5, but no promises.

@filipenevola filipenevola modified the milestones: Release 2.5, Release 2.6 Sep 23, 2021
@filipenevola filipenevola removed this from the Release 2.6 milestone Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed We want to fix or implement it Project:Isobuild
Projects
None yet
Development

No branches or pull requests

5 participants