Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include empty packages on the client #10701

Open
mitar opened this issue Sep 23, 2019 · 4 comments
Open

Do not include empty packages on the client #10701

mitar opened this issue Sep 23, 2019 · 4 comments
Labels
confirmed We want to fix or implement it Project:Isobuild

Comments

@mitar
Copy link
Contributor

mitar commented Sep 23, 2019

I am looking at a simple build of Meteor on the client and I see that packages which do not have any client code are still packaged and pushed to the client. I think this should be a simple optimization to not do that? I also think it would be pretty cool if Meteor would not leak to the client all server-side packages I might be using. It is true that in production those files become a very small line (just _define call), but still, I think it is unnecessary.

Tested with Meteor 1.8.1.

Examples:

//////////////////////////////////////////////////////////////////////////
//                                                                      //
// This is a generated file. You can view the original                  //
// source in your browser if your browser supports source maps.         //
// Source maps are supported by all recent versions of Chrome, Safari,  //
// and Firefox, and by Internet Explorer 11.                            //
//                                                                      //
//////////////////////////////////////////////////////////////////////////


(function () {



/* Exports */
Package._define("mobile-experience");

})();

And the same for:

  • static-files
  • standard-minifier-css
  • standard-minifier-js
  • es5-shim (on non-legacy browser)
  • modern-browsers
  • babel-compiler
  • ecmascript
  • shell-server
  • ecmascript-runtime (there is also ecmascript-runtime-client, why then two packages, if ecmascript-runtime is empty on the client)
@stale
Copy link

stale bot commented Dec 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale-bot label Dec 10, 2019
@mitar
Copy link
Contributor Author

mitar commented Dec 10, 2019

Still relevant.

@stale stale bot removed the stale-bot label Dec 10, 2019
@mitar mitar mentioned this issue Dec 10, 2019
@filipenevola filipenevola added the confirmed We want to fix or implement it label Dec 11, 2019
@stale
Copy link

stale bot commented Oct 31, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale-bot label Oct 31, 2020
@mitar
Copy link
Contributor Author

mitar commented Oct 31, 2020

Still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed We want to fix or implement it Project:Isobuild
Projects
None yet
Development

No branches or pull requests

3 participants