id-map should be modernized and existing logic moved to legacy

[mitar]

Now that we have modern/legacy browser separation, we could change id-map to simply be a Map with an existing id-map API on modern browsers, while keeping existing code to be used on legacy browser.

Alternatively, we could even replace id-map as a whole with simply a Map now, leaving to polyfills to implement Map to work over every key value. Interestingly though, these days id-map (since 79ae184), id-map is already using internally Map, but still does key stringification. That is not necessary anymore.

I am suspecting this would improve performance of Minimongo on the client as id-map is used there a lot. Moreover, id-map is used also in oplog driver on the server.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[mitar]

Still relevant.

[sebakerckhof]

@mitar The stringification is necessary in case you use mongo object ids.

[mitar]

Good point.

[sebakerckhof]

Do you want to keep this open? Maybe we could check the type before calling stringify, but I doubt it will bring any meaningful improvement.

[mitar]

It think it would be useful to determine if this is performance benefit for string IDs. If it is large, then it could be useful to have two code paths based on ID (we know which ID is being used per collection).

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[mitar]

I think this has been done? No? We are using map internally now?

[StorytellerCZ]

Just checked. As @mitar has stated id-map is using Map internally, but I haven't seen any move in DDP or MiniMongo to move to just a Map so the question is if we want to do more here or are we in a happy place at the moment.

[mitar]

Maybe open another issue for those two?