Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build plugins cannot access peer dependencies in the app #10827

Open
mitar opened this issue Dec 19, 2019 · 8 comments
Open

Build plugins cannot access peer dependencies in the app #10827

mitar opened this issue Dec 19, 2019 · 8 comments
Labels
confirmed We want to fix or implement it Project:Isobuild

Comments

@mitar
Copy link
Contributor

mitar commented Dec 19, 2019

Tested on Meteor 1.6.1.1.

I am observing this with two built plugins:

The issue is that these days many build plugins might allow configuration. For example, in postcss case they allow you to specify which plugins you want to operate on your CSS. So the reasonable approach would be that:

  • you install plugins you want at app-level
  • you configure them to be used

The issue is that plugins often then just try to do require(name_of_plugin). But this fails. The reason why this fails is because plugin seems to be run inside ~/.meteor namespace so resolving walks the tree there and not inside the app.

This is even more problematic because during development, if you have package inside packages in your app things look like working. But then, once published, they break.

@mitar
Copy link
Contributor Author

mitar commented Dec 19, 2019

Reopen of #9865.

@stale
Copy link

stale bot commented Jan 20, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale-bot label Jan 20, 2020
@mitar
Copy link
Contributor Author

mitar commented Jan 20, 2020

Unstale.

@stale stale bot removed the stale-bot label Jan 20, 2020
@filipenevola filipenevola added the confirmed We want to fix or implement it label Jan 21, 2020
@JohnAllen
Copy link

Very unstale, especially if this is the cause of juliancwirko/meteor-postcss not working (can't get it to work at all after 1-2 hours).

@stale
Copy link

stale bot commented Oct 31, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale-bot label Oct 31, 2020
@mitar
Copy link
Contributor Author

mitar commented Oct 31, 2020

Still relevant.

@Grubba27
Copy link
Contributor

As this issue has not had any activities in the last months... I will be closing it!
If further information is added, I will be happy to reopen this issue

@zodern
Copy link
Member

zodern commented Mar 23, 2023

This is still a problem. standard-minifier-css, zodern:melte and possibly other build plugins have to work around it.

@zodern zodern reopened this Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed We want to fix or implement it Project:Isobuild
Projects
None yet
Development

No branches or pull requests

6 participants