Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observe-sequence error in legacy bundle #11728

Open
nikparo opened this issue Jun 19, 2021 · 3 comments
Open

Observe-sequence error in legacy bundle #11728

nikparo opened this issue Jun 19, 2021 · 3 comments

Comments

@nikparo
Copy link

nikparo commented Jun 19, 2021

With the latest observe-sequence package in a Meteor 2.2 app, IE complained about a syntax error - ; expected. (We still maintain a legacy bundle, though hopefully it's on its last legs)

As far as I can tell it's caused by line 170 in observe_sequence.js:

for(var item of value) {

Clearly ES5 doesn't support for-of, but I'm not sure whether this is a transpilation/configuration issue or whether the line should be changed.

@jankapunkt
Copy link
Contributor

@StorytellerCZ you added bug label, is this a confirmed bug? I wonder if this rather might be a transpilation issue

@nikparo
Copy link
Author

nikparo commented Oct 7, 2021

I'm just wondering, at what stage is the transpilation meant to happen? At least as a meteor user for several years I have never had to worry about transpiling meteor packages.

@filipenevola
Copy link
Collaborator

Hi @nikparo can you provide a reproduction? Maybe this case is not well tested in our regression tests.

Also, I'm going to transfer this issue to Meteor repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants