Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accounts.createUser -> Meteor.logginIn issue #1243

Closed
copleykj opened this issue Jul 25, 2013 · 2 comments
Closed

Accounts.createUser -> Meteor.logginIn issue #1243

copleykj opened this issue Jul 25, 2013 · 2 comments

Comments

@copleykj
Copy link
Contributor

Accounts.createUser when called from the client currently sets Meteor.loggingIn to true even if createUser fails and throws an error. This causes applications that use the Meteor.logging in to display a loading page to re-render their template potentially causing loss of form values and validation errors displayed.

My personal thinking is that Meteor.loggingIn should not enter a true state unless account creation is successful.

@glasser
Copy link
Contributor

glasser commented Apr 22, 2014

The whole purpose of loggingIn is to be true while the login method (and createUser is a login method) is running, so this would defeat the point of uses loggingIn. Note that createUser is not a two step "create user then log in" process: it's just one round trip.

@glasser glasser closed this as completed Apr 22, 2014
@dburles
Copy link
Contributor

dburles commented Oct 24, 2016

What's the solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants