Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import/export should work in jsx files #5827

Closed
avital opened this issue Dec 18, 2015 · 4 comments
Closed

import/export should work in jsx files #5827

avital opened this issue Dec 18, 2015 · 4 comments
Milestone

Comments

@avital
Copy link
Contributor

avital commented Dec 18, 2015

Or should we deprecate the jsx package and unify it with ecmascript?

cc @benjamn @yyx990803

@benjamn
Copy link
Contributor

benjamn commented Dec 18, 2015

Merged JSX functionality into the ecmascript package: 86b743f

@benjamn benjamn closed this as completed Dec 18, 2015
@avital
Copy link
Contributor Author

avital commented Dec 18, 2015

Nice. So what happens to the jsx package we currently have? I guess we'll change it to imply ecmascript and print a warning that now your .js files are ES6 whether you want it or not?

@benjamn
Copy link
Contributor

benjamn commented Dec 18, 2015

Filed an issue that includes deprecating jsx: meteor/react-packages#152

The jsx package was already based on BabelCompiler, so making it imply ecmascript really shouldn't change anything anyone might care about.

@vjau
Copy link
Contributor

vjau commented Dec 19, 2015

With beta.1, meteor is complaining that

 While determining active plugins:
   error: conflict: two packages included in the app (jsx and ecmascript) are
   both trying to handle *.jsx

but jsx isn't in the package list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants