Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Meteor.user() and .userId() #7002

Closed
lorensr opened this issue May 7, 2016 · 2 comments
Closed

Improve Meteor.user() and .userId() #7002

lorensr opened this issue May 7, 2016 · 2 comments

Comments

@lorensr
Copy link
Contributor

lorensr commented May 7, 2016

I like Meteor.user(userId, fields) and Meteor.userId() work also inside the publish endpoint functions from https://github.com/peerlibrary/meteor-user-extra

Meteor.user() might be the largest culprit for reactivity bugs, and having userId work in pubs would simplify the api – I imagine that error you get when you try Meteor.userId() currently in publishers is pretty common.

Profile writability would be breaking: #3618 (comment)

Obviously it doesn't pass this test:

image

But I think there should be some exceptions to that rule ☺️

@mitar
Copy link
Contributor

mitar commented Sep 1, 2016

I must say that this my package surprises me again and again. :-) Because Meteor.userId() just works on the server. It is so easy to write code now which can run everywhere.

Also, I think that Blaze needs currentUserId besides just currentUser helper. Because often you just want to check if user is logged in, and not create dependency on the whole document.

@hwillson
Copy link
Contributor

hwillson commented Jun 9, 2017

To help provide a more clear separation between feature requests and bugs, and to help clean up the feature request backlog, Meteor feature requests are now being managed under the https://github.com/meteor/meteor-feature-requests repository.

Migrated to meteor/meteor-feature-requests#82.

@hwillson hwillson closed this as completed Jun 9, 2017
@meteor meteor locked and limited conversation to collaborators Jun 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants